search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.85k stars 124 forks source link

ci: Empty all QNS logs >5MB before artifact upload #2071

Closed larseggert closed 2 months ago

larseggert commented 2 months ago

Because these artifacts are huge and those logs are not useful for debugging.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.35%. Comparing base (adf4722) to head (19e9c5a). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2071 +/- ## ======================================= Coverage 95.35% 95.35% ======================================= Files 112 112 Lines 36505 36505 ======================================= Hits 34811 34811 Misses 1694 1694 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

github-actions[bot] commented 2 months ago

Benchmark results

Performance differences relative to adf4722206926903f951c9e313b23980cd2b4d02.

coalesce_acked_from_zero 1+1 entries: Change within noise threshold.
       time:   [99.426 ns 99.810 ns 100.22 ns]
       change: [+0.4686% +0.9220% +1.4267%] (p = 0.00 < 0.05)

Found 15 outliers among 100 measurements (15.00%)
  10 (10.00%) high mild
  5 (5.00%) high severe
coalesce_acked_from_zero 3+1 entries: Change within noise threshold.
       time:   [118.11 ns 118.39 ns 118.70 ns]
       change: [+0.1623% +0.8792% +1.9203%] (p = 0.03 < 0.05)

Found 16 outliers among 100 measurements (16.00%)
  2 (2.00%) low severe
  6 (6.00%) high mild
  8 (8.00%) high severe
coalesce_acked_from_zero 10+1 entries: Change within noise threshold.
       time:   [118.01 ns 118.56 ns 119.18 ns]
       change: [+0.1890% +0.7632% +1.3144%] (p = 0.01 < 0.05)

Found 18 outliers among 100 measurements (18.00%)
  5 (5.00%) low severe
  2 (2.00%) low mild
  1 (1.00%) high mild
  10 (10.00%) high severe
coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [98.061 ns 103.22 ns 114.47 ns]
       change: [+0.0832% +3.0167% +7.4749%] (p = 0.16 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
  3 (3.00%) high mild
  7 (7.00%) high severe
RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [111.28 ms 111.41 ms 111.63 ms]
       change: [-0.4412% -0.1905% +0.0526%] (p = 0.12 > 0.05)

Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) low mild
  1 (1.00%) high mild
  1 (1.00%) high severe
transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.976 ms 28.086 ms 29.194 ms]
       change: [-4.6893% +0.3117% +6.0980%] (p = 0.91 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [34.534 ms 36.001 ms 37.490 ms]
       change: [-6.9616% -0.5777% +6.2341%] (p = 0.86 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [31.319 ms 32.158 ms 32.971 ms]
       change: [-4.6868% -1.3193% +2.0166%] (p = 0.45 > 0.05)

Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) low mild
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [42.619 ms 45.608 ms 48.601 ms]
       change: [-14.808% -7.0115% +0.8266%] (p = 0.10 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold.
       time:   [115.23 ms 115.67 ms 116.10 ms]
       thrpt:  [861.30 MiB/s 864.50 MiB/s 867.79 MiB/s]
change:
       time:   [+0.0860% +0.9279% +1.6036%] (p = 0.01 < 0.05)
       thrpt:  [-1.5783% -0.9194% -0.0859%]

Found 3 outliers among 100 measurements (3.00%)
  2 (2.00%) low mild
  1 (1.00%) high mild
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [312.33 ms 316.24 ms 320.22 ms]
       thrpt:  [31.229 Kelem/s 31.622 Kelem/s 32.017 Kelem/s]
change:
       time:   [-1.4749% +0.1940% +2.0156%] (p = 0.83 > 0.05)
       thrpt:  [-1.9757% -0.1937% +1.4970%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [40.238 ms 40.940 ms 41.643 ms]
       thrpt:  [24.014  elem/s 24.426  elem/s 24.852  elem/s]
change:
       time:   [-1.7507% +0.6434% +3.0344%] (p = 0.61 > 0.05)
       thrpt:  [-2.9451% -0.6393% +1.7819%]

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 211.8 ± 123.0 94.4 582.7 1.00
neqo msquic reno on 271.6 ± 78.6 206.2 406.2 1.00
neqo msquic reno 258.1 ± 71.3 211.8 429.4 1.00
neqo msquic cubic on 219.3 ± 12.7 204.7 237.8 1.00
neqo msquic cubic 214.9 ± 12.8 201.9 243.3 1.00
msquic neqo reno on 92.9 ± 26.5 73.7 172.9 1.00
msquic neqo reno 147.1 ± 90.4 76.9 361.6 1.00
msquic neqo cubic on 105.4 ± 60.2 73.8 323.1 1.00
msquic neqo cubic 125.1 ± 84.2 74.6 325.5 1.00
neqo neqo reno on 200.4 ± 103.2 126.2 413.2 1.00
neqo neqo reno 178.1 ± 79.7 122.6 413.1 1.00
neqo neqo cubic on 256.6 ± 140.4 137.8 556.5 1.00
neqo neqo cubic 200.3 ± 77.7 139.7 391.4 1.00

:arrow_down: Download logs

github-actions[bot] commented 2 months ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.