search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.83k stars 123 forks source link

test(transport/ecn): cover disable on remark #2075

Closed mxinden closed 1 month ago

mxinden commented 1 month ago

Add test coverage for validation failing on Ect1.

https://github.com/mozilla/neqo/blob/15cae9be1529e327e575fb7c799acc7521691337/neqo-transport/src/ecn.rs#L244-L246

See missing coverage reported in https://github.com/mozilla/neqo/pull/2072.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.36%. Comparing base (15cae9b) to head (2fe40e3). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2075 +/- ## ======================================= Coverage 95.35% 95.36% ======================================= Files 112 112 Lines 36505 36505 ======================================= + Hits 34811 34813 +2 + Misses 1694 1692 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

github-actions[bot] commented 1 month ago

Benchmark results

Performance differences relative to 15cae9be1529e327e575fb7c799acc7521691337.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.129 ns 99.484 ns 99.879 ns]
       change: [-0.6985% -0.2508% +0.1609%] (p = 0.27 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
  4 (4.00%) high mild
  5 (5.00%) high severe
coalesce_acked_from_zero 3+1 entries: Change within noise threshold.
       time:   [117.68 ns 118.06 ns 118.46 ns]
       change: [-0.8834% -0.4785% -0.0236%] (p = 0.02 < 0.05)

Found 20 outliers among 100 measurements (20.00%)
  3 (3.00%) low severe
  4 (4.00%) high mild
  13 (13.00%) high severe
coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [117.17 ns 117.54 ns 118.02 ns]
       change: [-1.2884% -0.2569% +0.5518%] (p = 0.64 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
  3 (3.00%) low severe
  2 (2.00%) low mild
  1 (1.00%) high mild
  7 (7.00%) high severe
coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.339 ns 97.507 ns 97.704 ns]
       change: [-1.5931% -0.5853% +0.4654%] (p = 0.25 > 0.05)

Found 8 outliers among 100 measurements (8.00%)
  4 (4.00%) high mild
  4 (4.00%) high severe
RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [111.62 ms 111.75 ms 111.96 ms]
       change: [-0.1852% +0.0623% +0.3143%] (p = 0.68 > 0.05)

Found 17 outliers among 100 measurements (17.00%)
  1 (1.00%) low severe
  4 (4.00%) low mild
  10 (10.00%) high mild
  2 (2.00%) high severe
transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.463 ms 27.333 ms 28.204 ms]
       change: [-6.0765% -1.5280% +3.1296%] (p = 0.53 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [34.069 ms 35.788 ms 37.545 ms]
       change: [-10.704% -4.4879% +2.2054%] (p = 0.18 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [31.829 ms 32.552 ms 33.265 ms]
       change: [-4.2835% -1.1909% +2.1097%] (p = 0.47 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [40.114 ms 42.765 ms 45.451 ms]
       change: [-11.124% -3.5773% +5.8694%] (p = 0.41 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [114.06 ms 114.39 ms 114.71 ms]
       thrpt:  [871.75 MiB/s 874.24 MiB/s 876.71 MiB/s]
change:
       time:   [-1.2370% -0.3506% +0.2973%] (p = 0.43 > 0.05)
       thrpt:  [-0.2964% +0.3519% +1.2524%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [312.23 ms 315.78 ms 319.38 ms]
       thrpt:  [31.311 Kelem/s 31.668 Kelem/s 32.028 Kelem/s]
change:
       time:   [-1.9767% -0.3517% +1.2939%] (p = 0.67 > 0.05)
       thrpt:  [-1.2774% +0.3529% +2.0166%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [40.483 ms 41.181 ms 41.874 ms]
       thrpt:  [23.881  elem/s 24.283  elem/s 24.702  elem/s]
change:
       time:   [-2.2069% +0.2261% +2.5802%] (p = 0.85 > 0.05)
       thrpt:  [-2.5153% -0.2255% +2.2567%]

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 109.8 ± 44.2 83.6 255.6 1.00
neqo msquic reno on 218.2 ± 13.7 203.6 244.2 1.00
neqo msquic reno 212.6 ± 6.8 203.9 225.6 1.00
neqo msquic cubic on 229.2 ± 13.7 206.3 246.8 1.00
neqo msquic cubic 212.7 ± 6.8 202.3 228.0 1.00
msquic neqo reno on 99.1 ± 51.8 74.0 364.9 1.00
msquic neqo reno 82.7 ± 9.7 75.5 105.2 1.00
msquic neqo cubic on 89.2 ± 24.5 74.2 177.3 1.00
msquic neqo cubic 87.3 ± 21.7 74.9 173.1 1.00
neqo neqo reno on 195.1 ± 102.1 124.0 411.5 1.00
neqo neqo reno 181.7 ± 91.7 125.8 461.3 1.00
neqo neqo cubic on 172.1 ± 41.2 123.8 307.2 1.00
neqo neqo cubic 242.1 ± 109.4 127.8 440.6 1.00

:arrow_down: Download logs

github-actions[bot] commented 1 month ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.