search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.83k stars 123 forks source link

fix: Don't panic on Windows if `GITHUB_WORKFLOW` is not set #2079

Closed larseggert closed 1 month ago

github-actions[bot] commented 1 month ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

github-actions[bot] commented 1 month ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.36%. Comparing base (9e8d298) to head (3eff863). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2079 +/- ## ======================================= Coverage 95.36% 95.36% ======================================= Files 112 112 Lines 36505 36505 ======================================= Hits 34813 34813 Misses 1692 1692 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Benchmark results

Performance differences relative to 9e8d298d1ab597b55446766ff8816b06ae3f0db4.

coalesce_acked_from_zero 1+1 entries: Change within noise threshold.
       time:   [98.441 ns 98.704 ns 98.972 ns]
       change: [-1.1806% -0.7826% -0.3932%] (p = 0.00 < 0.05)

Found 7 outliers among 100 measurements (7.00%)
  1 (1.00%) high mild
  6 (6.00%) high severe
coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.17 ns 117.56 ns 117.98 ns]
       change: [-0.8771% -0.2500% +0.3741%] (p = 0.46 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
  14 (14.00%) high severe
coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.79 ns 117.32 ns 117.92 ns]
       change: [-0.8165% -0.4069% -0.0097%] (p = 0.05 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
  4 (4.00%) low severe
  3 (3.00%) low mild
  1 (1.00%) high mild
  10 (10.00%) high severe
coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.079 ns 102.70 ns 114.97 ns]
       change: [-1.8355% +1.0826% +5.1256%] (p = 0.70 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
  4 (4.00%) high mild
  6 (6.00%) high severe
RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [111.32 ms 111.46 ms 111.67 ms]
       change: [-0.0718% +0.0595% +0.2376%] (p = 0.61 > 0.05)

Found 4 outliers among 100 measurements (4.00%)
  2 (2.00%) low mild
  1 (1.00%) high mild
  1 (1.00%) high severe
transfer/pacing-false/varying-seeds: Change within noise threshold.
       time:   [27.553 ms 28.432 ms 29.306 ms]
       change: [+0.3995% +5.4525% +10.775%] (p = 0.04 < 0.05)

Found 6 outliers among 100 measurements (6.00%)
  2 (2.00%) low mild
  4 (4.00%) high mild
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [33.246 ms 34.742 ms 36.256 ms]
       change: [-10.242% -4.4470% +1.9115%] (p = 0.17 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [31.448 ms 32.149 ms 32.826 ms]
       change: [-2.6994% +0.1189% +3.0364%] (p = 0.93 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) low mild
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [40.480 ms 43.327 ms 46.203 ms]
       change: [-10.092% -0.8001% +10.356%] (p = 0.88 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [113.49 ms 114.53 ms 115.89 ms]
       thrpt:  [862.86 MiB/s 873.17 MiB/s 881.12 MiB/s]
change:
       time:   [-1.3378% -0.3761% +0.7710%] (p = 0.54 > 0.05)
       thrpt:  [-0.7651% +0.3776% +1.3559%]

Found 6 outliers among 100 measurements (6.00%)
  1 (1.00%) low severe
  3 (3.00%) low mild
  2 (2.00%) high severe
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [309.41 ms 312.90 ms 316.45 ms]
       thrpt:  [31.600 Kelem/s 31.959 Kelem/s 32.320 Kelem/s]
change:
       time:   [-1.5969% -0.0421% +1.6011%] (p = 0.96 > 0.05)
       thrpt:  [-1.5759% +0.0422% +1.6228%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [40.517 ms 41.227 ms 41.937 ms]
       thrpt:  [23.845  elem/s 24.256  elem/s 24.681  elem/s]
change:
       time:   [-2.3999% -0.0572% +2.3766%] (p = 0.97 > 0.05)
       thrpt:  [-2.3214% +0.0572% +2.4589%]

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 173.8 ± 114.7 85.8 551.4 1.00
neqo msquic reno on 271.4 ± 75.2 218.3 465.0 1.00
neqo msquic reno 256.7 ± 72.1 219.4 430.7 1.00
neqo msquic cubic on 217.5 ± 10.4 203.4 232.5 1.00
neqo msquic cubic 266.3 ± 75.2 217.1 460.6 1.00
msquic neqo reno on 82.9 ± 11.7 74.3 115.8 1.00
msquic neqo reno 102.9 ± 62.7 74.3 353.1 1.00
msquic neqo cubic on 86.9 ± 19.9 74.1 165.0 1.00
msquic neqo cubic 129.8 ± 107.8 73.6 523.6 1.00
neqo neqo reno on 164.6 ± 65.4 123.5 372.1 1.00
neqo neqo reno 138.2 ± 15.1 122.9 174.0 1.00
neqo neqo cubic on 173.7 ± 47.8 127.7 252.7 1.00
neqo neqo cubic 221.3 ± 132.6 127.2 644.3 1.00

:arrow_down: Download logs