search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.85k stars 124 forks source link

build(deps): bump actions/upload-artifact from 4.3.6 to 4.4.0 #2083

Closed dependabot[bot] closed 2 months ago

dependabot[bot] commented 2 months ago

Bumps actions/upload-artifact from 4.3.6 to 4.4.0.

Release notes

Sourced from actions/upload-artifact's releases.

v4.4.0

Notice: Breaking Changes :warning:

We will no longer include hidden files and folders by default in the upload-artifact action of this version. This reduces the risk that credentials are accidentally uploaded into artifacts. Customers who need to continue to upload these files can use a new option, include-hidden-files, to continue to do so.

See "Notice of upcoming deprecations and breaking changes in GitHub Actions runners" changelog and this issue for more details.

What's Changed

Full Changelog: https://github.com/actions/upload-artifact/compare/v4.3.6...v4.4.0

Commits
  • 5076954 Merge pull request #598 from actions/joshmgross/exclude-hidden-files
  • d52396a Add a warning about enabling include-hidden-files
  • 710f362 Remove "merged" from include-hidden-files input description
  • 3b315f2 npm run release again 🙂
  • 3be2180 Remove another trailing comma
  • 453e8d0 Update glob license
  • 0a398c1 npm run release
  • a0c40cf Update to latest @actions/glob and fix tests
  • acb59e4 lint
  • cb6558b Exclude hidden files by default
  • See full diff in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
github-actions[bot] commented 2 months ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

github-actions[bot] commented 2 months ago

Benchmark results

Performance differences relative to 7139f5792e20270cc36ced4af37c11c5d3733bf9.

coalesce_acked_from_zero 1+1 entries: Change within noise threshold.
       time:   [99.325 ns 99.649 ns 99.984 ns]
       change: [+0.2294% +0.6485% +1.1123%] (p = 0.00 < 0.05)

Found 13 outliers among 100 measurements (13.00%)
  9 (9.00%) high mild
  4 (4.00%) high severe
coalesce_acked_from_zero 3+1 entries: Change within noise threshold.
       time:   [117.99 ns 118.29 ns 118.64 ns]
       change: [+0.5486% +1.0273% +1.6273%] (p = 0.00 < 0.05)

Found 20 outliers among 100 measurements (20.00%)
  1 (1.00%) low severe
  3 (3.00%) low mild
  4 (4.00%) high mild
  12 (12.00%) high severe
coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [117.64 ns 118.30 ns 119.27 ns]
       change: [-0.1772% +0.9106% +2.0765%] (p = 0.13 > 0.05)

Found 17 outliers among 100 measurements (17.00%)
  5 (5.00%) low severe
  3 (3.00%) low mild
  9 (9.00%) high severe
coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [99.097 ns 99.283 ns 99.500 ns]
       change: [-9.8041% -1.4394% +3.9091%] (p = 0.80 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
  4 (4.00%) high mild
  5 (5.00%) high severe
RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [112.26 ms 112.40 ms 112.63 ms]
       change: [+0.1918% +0.3767% +0.5896%] (p = 0.00 < 0.05)

Found 9 outliers among 100 measurements (9.00%)
  5 (5.00%) low mild
  2 (2.00%) high mild
  2 (2.00%) high severe
transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.628 ms 27.659 ms 28.666 ms]
       change: [-4.4097% +0.6786% +6.2839%] (p = 0.80 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) low mild
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [35.201 ms 36.790 ms 38.426 ms]
       change: [-7.5153% -1.4276% +5.1177%] (p = 0.66 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [31.803 ms 32.448 ms 33.087 ms]
       change: [-2.6258% +0.5292% +3.7411%] (p = 0.74 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [45.082 ms 47.736 ms 50.358 ms]
       change: [-0.2767% +9.4525% +20.506%] (p = 0.06 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) low mild
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [113.61 ms 114.10 ms 114.58 ms]
       thrpt:  [872.75 MiB/s 876.40 MiB/s 880.24 MiB/s]
change:
       time:   [-0.5701% +0.0338% +0.6169%] (p = 0.92 > 0.05)
       thrpt:  [-0.6131% -0.0338% +0.5734%]

Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) low mild
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [317.49 ms 320.81 ms 324.08 ms]
       thrpt:  [30.856 Kelem/s 31.171 Kelem/s 31.497 Kelem/s]
change:
       time:   [-2.2227% -0.7278% +0.7850%] (p = 0.34 > 0.05)
       thrpt:  [-0.7789% +0.7332% +2.2732%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [32.391 ms 32.598 ms 32.823 ms]
       thrpt:  [30.467  elem/s 30.677  elem/s 30.872  elem/s]
change:
       time:   [-0.5730% +0.2630% +1.0970%] (p = 0.55 > 0.05)
       thrpt:  [-1.0851% -0.2623% +0.5763%]

Found 9 outliers among 100 measurements (9.00%)
  2 (2.00%) low mild
  1 (1.00%) high mild
  6 (6.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 102.0 ± 24.9 82.8 191.5 1.00
neqo msquic reno on 214.4 ± 10.8 206.2 246.4 1.00
neqo msquic reno 216.7 ± 11.6 202.3 235.8 1.00
neqo msquic cubic on 216.2 ± 11.9 204.2 243.2 1.00
neqo msquic cubic 213.6 ± 9.6 203.2 237.5 1.00
msquic neqo reno on 81.9 ± 10.8 73.9 117.8 1.00
msquic neqo reno 83.2 ± 12.8 74.3 121.6 1.00
msquic neqo cubic on 83.5 ± 17.5 73.8 159.7 1.00
msquic neqo cubic 100.3 ± 42.4 74.4 206.0 1.00
neqo neqo reno on 175.5 ± 48.7 129.5 282.9 1.00
neqo neqo reno 157.7 ± 63.6 123.5 376.5 1.00
neqo neqo cubic on 168.1 ± 39.4 124.3 295.0 1.00
neqo neqo cubic 156.2 ± 29.1 123.9 226.5 1.00

:arrow_down: Download logs

github-actions[bot] commented 2 months ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.35%. Comparing base (6f8823b) to head (0e1f554). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2083 +/- ## ========================================== - Coverage 95.36% 95.35% -0.01% ========================================== Files 112 112 Lines 36530 36530 ========================================== - Hits 34836 34835 -1 - Misses 1694 1695 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.