search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.85k stars 124 forks source link

ci: Retry the Rust cache #2089

Closed larseggert closed 2 months ago

larseggert commented 2 months ago

And maybe buildjet.

github-actions[bot] commented 2 months ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

github-actions[bot] commented 2 months ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.33%. Comparing base (28f60bd) to head (64f2e3c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2089 +/- ## ========================================== - Coverage 95.36% 95.33% -0.04% ========================================== Files 112 112 Lines 36559 36300 -259 ========================================== - Hits 34866 34608 -258 + Misses 1693 1692 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

larseggert commented 2 months ago

Still slower than not caching :-(

github-actions[bot] commented 2 months ago

Benchmark results

Performance differences relative to 28f60bd0ba3209ecba4102eec123859a3a8afd45.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [98.954 ns 99.517 ns 100.36 ns]
       change: [-0.9087% -0.1980% +0.4635%] (p = 0.61 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
  8 (8.00%) high mild
  3 (3.00%) high severe
coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.05 ns 117.44 ns 117.85 ns]
       change: [-0.3359% +0.3087% +0.9860%] (p = 0.39 > 0.05)

Found 20 outliers among 100 measurements (20.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
  18 (18.00%) high severe
coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.30 ns 116.62 ns 117.06 ns]
       change: [-0.9559% -0.3544% +0.2061%] (p = 0.25 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
  5 (5.00%) low severe
  4 (4.00%) low mild
  4 (4.00%) high mild
  5 (5.00%) high severe
coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.570 ns 97.712 ns 97.873 ns]
       change: [-1.0924% -0.2919% +0.4990%] (p = 0.48 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
  4 (4.00%) high mild
  10 (10.00%) high severe
RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.47 ms 111.52 ms 111.58 ms]
       change: [-0.6856% -0.6184% -0.5484%] (p = 0.00 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) low mild
transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.926 ms 27.937 ms 28.957 ms]
       change: [-4.2244% +1.0260% +6.9576%] (p = 0.72 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [34.810 ms 36.579 ms 38.332 ms]
       change: [-10.275% -4.2649% +2.5372%] (p = 0.19 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [32.355 ms 33.093 ms 33.805 ms]
       change: [-3.8138% -0.7482% +2.3550%] (p = 0.63 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) low mild
transfer/pacing-true/same-seed: Change within noise threshold.
       time:   [46.710 ms 49.698 ms 52.630 ms]
       change: [+2.0873% +11.353% +21.174%] (p = 0.01 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) low mild
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [114.48 ms 115.09 ms 115.93 ms]
       thrpt:  [862.57 MiB/s 868.92 MiB/s 873.49 MiB/s]
change:
       time:   [-1.0384% -0.2988% +0.5083%] (p = 0.48 > 0.05)
       thrpt:  [-0.5058% +0.2997% +1.0493%]

Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high severe
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [315.45 ms 318.80 ms 322.13 ms]
       thrpt:  [31.043 Kelem/s 31.368 Kelem/s 31.701 Kelem/s]
change:
       time:   [-2.1636% -0.6662% +0.7860%] (p = 0.37 > 0.05)
       thrpt:  [-0.7799% +0.6706% +2.2115%]

Found 5 outliers among 100 measurements (5.00%)
  2 (2.00%) low mild
  3 (3.00%) high mild
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [32.463 ms 32.656 ms 32.865 ms]
       thrpt:  [30.428  elem/s 30.622  elem/s 30.804  elem/s]
change:
       time:   [-0.2875% +0.4632% +1.1513%] (p = 0.22 > 0.05)
       thrpt:  [-1.1382% -0.4611% +0.2883%]

Found 8 outliers among 100 measurements (8.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
  6 (6.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 170.4 ± 89.8 96.4 346.0 1.00
neqo msquic reno on 247.5 ± 81.6 208.7 505.3 1.00
neqo msquic reno 262.5 ± 80.6 214.1 477.6 1.00
neqo msquic cubic on 247.3 ± 79.4 207.2 471.1 1.00
neqo msquic cubic 223.1 ± 11.0 208.9 238.1 1.00
msquic neqo reno on 155.9 ± 87.3 88.2 367.2 1.00
msquic neqo reno 175.1 ± 125.2 78.9 490.9 1.00
msquic neqo cubic on 160.7 ± 101.0 80.3 413.4 1.00
msquic neqo cubic 129.6 ± 76.2 79.1 361.3 1.00
neqo neqo reno on 205.1 ± 84.3 130.9 386.8 1.00
neqo neqo reno 230.8 ± 103.4 139.3 420.6 1.00
neqo neqo cubic on 254.2 ± 118.6 140.4 468.2 1.00
neqo neqo cubic 181.0 ± 53.8 120.0 364.8 1.00

:arrow_down: Download logs