search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.85k stars 124 forks source link

chore: Trim unused features #2090

Closed larseggert closed 2 months ago

larseggert commented 2 months ago

Courtesy of https://github.com/ToBinio/cargo-features-manager.

github-actions[bot] commented 2 months ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

github-actions[bot] commented 2 months ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.33%. Comparing base (28f60bd) to head (58e93d7). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2090 +/- ## ========================================== - Coverage 95.36% 95.33% -0.04% ========================================== Files 112 112 Lines 36559 36300 -259 ========================================== - Hits 34866 34608 -258 + Misses 1693 1692 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Benchmark results

Performance differences relative to 28f60bd0ba3209ecba4102eec123859a3a8afd45.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.614 ns 99.976 ns 100.33 ns]
       change: [-0.2703% +0.3692% +0.9348%] (p = 0.25 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
  11 (11.00%) high mild
  3 (3.00%) high severe
coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.25 ns 117.55 ns 117.88 ns]
       change: [-0.2873% +0.1360% +0.5234%] (p = 0.53 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
  1 (1.00%) low mild
  3 (3.00%) high mild
  9 (9.00%) high severe
coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.92 ns 117.26 ns 117.70 ns]
       change: [-0.2510% +0.5829% +1.5478%] (p = 0.21 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
  1 (1.00%) low severe
  5 (5.00%) low mild
  1 (1.00%) high mild
  6 (6.00%) high severe
coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.387 ns 97.499 ns 97.632 ns]
       change: [-0.7123% +0.1864% +1.2283%] (p = 0.72 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
  5 (5.00%) high mild
  6 (6.00%) high severe
RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.53 ms 111.60 ms 111.66 ms]
       change: [-0.6310% -0.5543% -0.4820%] (p = 0.00 < 0.05)

Found 5 outliers among 100 measurements (5.00%)
  5 (5.00%) low mild
transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.807 ms 27.806 ms 28.807 ms]
       change: [-4.3948% +0.5521% +5.7756%] (p = 0.84 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [34.348 ms 36.117 ms 37.895 ms]
       change: [-11.500% -5.4747% +1.3567%] (p = 0.10 > 0.05)

Found 5 outliers among 100 measurements (5.00%)
  2 (2.00%) low mild
  3 (3.00%) high mild
transfer/pacing-false/same-seed: Change within noise threshold.
       time:   [30.805 ms 31.655 ms 32.474 ms]
       change: [-8.0793% -5.0616% -1.5847%] (p = 0.00 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) low mild
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [42.878 ms 45.226 ms 47.600 ms]
       change: [-6.6088% +1.3338% +10.461%] (p = 0.75 > 0.05)

Found 4 outliers among 100 measurements (4.00%)
  1 (1.00%) low mild
  3 (3.00%) high mild
1-conn/1-100mb-resp (aka. Download)/client: :green_heart: Performance has improved.
       time:   [113.17 ms 113.59 ms 113.99 ms]
       thrpt:  [877.28 MiB/s 880.38 MiB/s 883.61 MiB/s]
change:
       time:   [-2.1616% -1.5972% -1.0315%] (p = 0.00 < 0.05)
       thrpt:  [+1.0423% +1.6232% +2.2094%]

Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) low mild
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: Change within noise threshold.
       time:   [311.23 ms 314.79 ms 318.37 ms]
       thrpt:  [31.410 Kelem/s 31.767 Kelem/s 32.130 Kelem/s]
change:
       time:   [-3.4718% -1.9131% -0.3548%] (p = 0.01 < 0.05)
       thrpt:  [+0.3561% +1.9504% +3.5967%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [32.433 ms 32.619 ms 32.820 ms]
       thrpt:  [30.469  elem/s 30.657  elem/s 30.833  elem/s]
change:
       time:   [-0.3533% +0.3505% +1.0219%] (p = 0.33 > 0.05)
       thrpt:  [-1.0116% -0.3493% +0.3546%]

Found 7 outliers among 100 measurements (7.00%)
  2 (2.00%) high mild
  5 (5.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 100.6 ± 20.5 85.9 171.0 1.00
neqo msquic reno on 216.4 ± 7.4 207.3 232.8 1.00
neqo msquic reno 216.8 ± 7.3 209.3 236.8 1.00
neqo msquic cubic on 219.5 ± 10.2 207.1 238.0 1.00
neqo msquic cubic 223.8 ± 12.7 207.7 244.8 1.00
msquic neqo reno on 91.5 ± 20.6 77.3 183.6 1.00
msquic neqo reno 85.4 ± 11.2 75.7 130.7 1.00
msquic neqo cubic on 90.0 ± 18.1 74.3 166.5 1.00
msquic neqo cubic 92.0 ± 22.1 72.5 154.1 1.00
neqo neqo reno on 190.4 ± 99.4 127.0 434.0 1.00
neqo neqo reno 167.9 ± 84.7 128.2 479.2 1.00
neqo neqo cubic on 172.8 ± 73.4 128.5 458.1 1.00
neqo neqo cubic 197.4 ± 95.6 122.9 409.9 1.00

:arrow_down: Download logs