search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.83k stars 123 forks source link

ci(rust): add `targets` input #2099

Closed mxinden closed 2 weeks ago

mxinden commented 2 weeks ago

Needed for https://github.com/mozilla/mtu/pull/21.

github-actions[bot] commented 2 weeks ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.33%. Comparing base (dc068f9) to head (5ef8c35). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2099 +/- ## ======================================= Coverage 95.33% 95.33% ======================================= Files 112 112 Lines 36300 36300 ======================================= Hits 34608 34608 Misses 1692 1692 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

github-actions[bot] commented 2 weeks ago

Benchmark results

Performance differences relative to dc068f9946122462e6b867b12ff3067e659b0ac6.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.311 ns 99.669 ns 100.01 ns]
       change: [-0.0350% +0.5401% +1.3386%] (p = 0.12 > 0.05)

Found 6 outliers among 100 measurements (6.00%)
  3 (3.00%) high mild
  3 (3.00%) high severe
coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.13 ns 117.49 ns 117.88 ns]
       change: [-0.4170% +0.0020% +0.3811%] (p = 0.99 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
  2 (2.00%) low mild
  13 (13.00%) high severe
coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.66 ns 117.10 ns 117.64 ns]
       change: [-0.2337% +0.1937% +0.6125%] (p = 0.44 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
  3 (3.00%) low severe
  6 (6.00%) high severe
coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.192 ns 97.359 ns 97.550 ns]
       change: [-0.7181% +0.3101% +1.3862%] (p = 0.59 > 0.05)

Found 8 outliers among 100 measurements (8.00%)
  2 (2.00%) high mild
  6 (6.00%) high severe
RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.44 ms 111.49 ms 111.54 ms]
       change: [-1.0347% -0.8412% -0.7121%] (p = 0.00 < 0.05)

Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) low mild
transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [25.621 ms 26.526 ms 27.420 ms]
       change: [-6.8554% -2.0021% +3.2220%] (p = 0.43 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [35.423 ms 36.917 ms 38.404 ms]
       change: [-1.1820% +5.2043% +12.100%] (p = 0.11 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [31.527 ms 32.248 ms 32.961 ms]
       change: [-3.4143% -0.1714% +3.1206%] (p = 0.92 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [44.187 ms 47.010 ms 49.831 ms]
       change: [-7.4945% +0.8653% +10.238%] (p = 0.84 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [113.20 ms 113.71 ms 114.19 ms]
       thrpt:  [875.76 MiB/s 879.44 MiB/s 883.39 MiB/s]
change:
       time:   [-0.7771% -0.2463% +0.2427%] (p = 0.36 > 0.05)
       thrpt:  [-0.2421% +0.2469% +0.7832%]

Found 5 outliers among 100 measurements (5.00%)
  2 (2.00%) low severe
  2 (2.00%) low mild
  1 (1.00%) high mild
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [309.73 ms 313.85 ms 318.01 ms]
       thrpt:  [31.446 Kelem/s 31.863 Kelem/s 32.286 Kelem/s]
change:
       time:   [-2.0982% -0.3087% +1.5368%] (p = 0.74 > 0.05)
       thrpt:  [-1.5136% +0.3096% +2.1431%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [33.933 ms 34.160 ms 34.406 ms]
       thrpt:  [29.065  elem/s 29.274  elem/s 29.470  elem/s]
change:
       time:   [-0.1074% +0.7713% +1.7281%] (p = 0.10 > 0.05)
       thrpt:  [-1.6987% -0.7654% +0.1075%]

Found 8 outliers among 100 measurements (8.00%)
  4 (4.00%) high mild
  4 (4.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 184.3 ± 96.3 90.9 349.5 1.00
neqo msquic reno on 301.2 ± 96.3 214.1 472.5 1.00
neqo msquic reno 244.4 ± 55.1 218.3 415.4 1.00
neqo msquic cubic on 218.8 ± 19.1 203.4 265.0 1.00
neqo msquic cubic 233.5 ± 32.3 204.2 313.6 1.00
msquic neqo reno on 179.7 ± 130.9 82.1 476.7 1.00
msquic neqo reno 127.4 ± 78.2 82.8 340.8 1.00
msquic neqo cubic on 140.1 ± 80.5 81.6 349.0 1.00
msquic neqo cubic 143.5 ± 88.6 81.4 324.3 1.00
neqo neqo reno on 184.2 ± 80.5 128.4 361.3 1.00
neqo neqo reno 231.4 ± 108.1 132.3 447.0 1.00
neqo neqo cubic on 229.3 ± 135.0 126.9 594.4 1.00
neqo neqo cubic 202.7 ± 81.1 123.5 361.9 1.00

:arrow_down: Download logs