search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.83k stars 123 forks source link

ci: Pin NSS to prevent build hang on Windows #2106

Closed larseggert closed 2 weeks ago

larseggert commented 2 weeks ago

The MLKEM patches make the NSS build on Windows hang indefinitely. Until we fix that, pin NSS to the last working revision before MLKEM landed.

(Also switch to using actions/checkout and hence don't install mercurial anymore.)

CC @jschanck

github-actions[bot] commented 2 weeks ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

github-actions[bot] commented 2 weeks ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.33%. Comparing base (46e15cb) to head (c64810d). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2106 +/- ## ======================================= Coverage 95.33% 95.33% ======================================= Files 112 112 Lines 36287 36300 +13 ======================================= + Hits 34594 34608 +14 + Misses 1693 1692 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

Benchmark results

Performance differences relative to 0b106c286f8f9c879f2122daab9e8bd12aa9a703.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.270 ns 99.569 ns 99.880 ns]
       change: [-0.4520% +0.1338% +0.6376%] (p = 0.66 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
  5 (5.00%) high mild
  6 (6.00%) high severe
coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.20 ns 117.54 ns 117.90 ns]
       change: [-0.2499% +0.1380% +0.4788%] (p = 0.48 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
  2 (2.00%) low severe
  5 (5.00%) high mild
  9 (9.00%) high severe
coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.71 ns 116.96 ns 117.32 ns]
       change: [-0.4114% +0.0412% +0.4581%] (p = 0.86 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
  5 (5.00%) low severe
  4 (4.00%) low mild
  1 (1.00%) high mild
  3 (3.00%) high severe
coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.482 ns 97.593 ns 97.727 ns]
       change: [-0.9965% -0.1404% +0.6340%] (p = 0.75 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
  4 (4.00%) high mild
  6 (6.00%) high severe
RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.70 ms 111.76 ms 111.81 ms]
       change: [+0.2700% +0.3405% +0.4083%] (p = 0.00 < 0.05)

Found 8 outliers among 100 measurements (8.00%)
  5 (5.00%) low mild
  3 (3.00%) high mild
transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [27.238 ms 28.301 ms 29.379 ms]
       change: [-4.1352% +0.9372% +6.3279%] (p = 0.73 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [35.006 ms 36.634 ms 38.277 ms]
       change: [-4.8503% +1.3002% +7.6053%] (p = 0.69 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [32.160 ms 32.847 ms 33.519 ms]
       change: [-2.6082% +0.3149% +3.3946%] (p = 0.84 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [45.345 ms 48.349 ms 51.310 ms]
       change: [-3.6832% +6.2947% +16.416%] (p = 0.21 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) low mild
1-conn/1-100mb-resp (aka. Download)/client: :green_heart: Performance has improved.
       time:   [112.64 ms 113.15 ms 113.63 ms]
       thrpt:  [880.03 MiB/s 883.75 MiB/s 887.75 MiB/s]
change:
       time:   [-2.2509% -1.6509% -1.1015%] (p = 0.00 < 0.05)
       thrpt:  [+1.1138% +1.6786% +2.3027%]

Found 5 outliers among 100 measurements (5.00%)
  5 (5.00%) low mild
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [312.80 ms 316.03 ms 319.26 ms]
       thrpt:  [31.322 Kelem/s 31.642 Kelem/s 31.970 Kelem/s]
change:
       time:   [-2.3016% -0.7866% +0.7395%] (p = 0.32 > 0.05)
       thrpt:  [-0.7341% +0.7929% +2.3558%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [33.719 ms 33.942 ms 34.179 ms]
       thrpt:  [29.258  elem/s 29.462  elem/s 29.657  elem/s]
change:
       time:   [-1.5092% -0.5948% +0.3464%] (p = 0.22 > 0.05)
       thrpt:  [-0.3452% +0.5984% +1.5323%]

Found 7 outliers among 100 measurements (7.00%)
  4 (4.00%) high mild
  3 (3.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 163.0 ± 89.4 100.1 391.1 1.00
neqo msquic reno on 250.5 ± 63.9 213.9 427.1 1.00
neqo msquic reno 258.7 ± 70.2 218.1 453.4 1.00
neqo msquic cubic on 335.6 ± 135.2 218.3 621.4 1.00
neqo msquic cubic 268.5 ± 79.7 214.5 430.8 1.00
msquic neqo reno on 169.6 ± 105.9 88.8 387.3 1.00
msquic neqo reno 197.5 ± 119.9 94.6 575.1 1.00
msquic neqo cubic on 149.1 ± 88.0 81.6 334.0 1.00
msquic neqo cubic 178.7 ± 94.7 93.2 352.0 1.00
neqo neqo reno on 255.3 ± 158.6 139.0 600.3 1.00
neqo neqo reno 195.4 ± 108.7 122.6 439.4 1.00
neqo neqo cubic on 216.6 ± 109.5 127.3 528.7 1.00
neqo neqo cubic 226.3 ± 130.0 134.0 631.5 1.00

:arrow_down: Download logs