search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.83k stars 123 forks source link

ci: Unpin nss #2108

Closed larseggert closed 2 weeks ago

larseggert commented 2 weeks ago

Verbose, single-threaded build

github-actions[bot] commented 2 weeks ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

github-actions[bot] commented 2 weeks ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.35%. Comparing base (2ca29c1) to head (121b8a6). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2108 +/- ## ========================================== - Coverage 95.35% 95.35% -0.01% ========================================== Files 112 112 Lines 36325 36325 ========================================== - Hits 34638 34636 -2 - Misses 1687 1689 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

Benchmark results

Performance differences relative to d4978debe744a3099eb8f854e1cacc2c1ec4e21e.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.404 ns 99.718 ns 100.04 ns]
       change: [-0.2598% +0.2207% +0.7144%] (p = 0.37 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
  8 (8.00%) high mild
  3 (3.00%) high severe
coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.57 ns 117.99 ns 118.45 ns]
       change: [-0.2521% +0.4417% +1.1568%] (p = 0.24 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
  1 (1.00%) low mild
  15 (15.00%) high severe
coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [117.18 ns 117.68 ns 118.28 ns]
       change: [-0.2063% +0.8529% +2.1332%] (p = 0.16 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
  1 (1.00%) low severe
  1 (1.00%) high mild
  9 (9.00%) high severe
coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.971 ns 98.163 ns 98.364 ns]
       change: [-0.3230% +0.4631% +1.2049%] (p = 0.25 > 0.05)

Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe
RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [111.66 ms 111.79 ms 112.01 ms]
       change: [-0.3708% -0.1275% +0.1404%] (p = 0.35 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
  7 (7.00%) low mild
  8 (8.00%) high mild
  1 (1.00%) high severe
transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.398 ms 27.469 ms 28.544 ms]
       change: [-9.2402% -4.1485% +0.7478%] (p = 0.13 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [34.964 ms 36.374 ms 37.747 ms]
       change: [-9.2349% -4.1057% +1.3619%] (p = 0.14 > 0.05)
transfer/pacing-false/same-seed: :green_heart: Performance has improved.
       time:   [30.614 ms 31.330 ms 32.022 ms]
       change: [-9.3081% -6.3588% -3.2595%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) low mild
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [40.193 ms 42.771 ms 45.374 ms]
       change: [-2.1370% +8.3009% +19.945%] (p = 0.12 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold.
       time:   [114.15 ms 114.63 ms 115.07 ms]
       thrpt:  [869.00 MiB/s 872.38 MiB/s 876.01 MiB/s]
change:
       time:   [+0.8342% +1.3292% +1.8700%] (p = 0.00 < 0.05)
       thrpt:  [-1.8357% -1.3117% -0.8273%]

Found 3 outliers among 100 measurements (3.00%)
  1 (1.00%) low severe
  2 (2.00%) low mild
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [314.62 ms 318.24 ms 321.85 ms]
       thrpt:  [31.070 Kelem/s 31.423 Kelem/s 31.785 Kelem/s]
change:
       time:   [-0.4305% +1.1899% +2.8247%] (p = 0.15 > 0.05)
       thrpt:  [-2.7471% -1.1759% +0.4324%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [33.597 ms 33.761 ms 33.932 ms]
       thrpt:  [29.471  elem/s 29.620  elem/s 29.765  elem/s]
change:
       time:   [-1.3634% -0.6858% +0.0525%] (p = 0.05 > 0.05)
       thrpt:  [-0.0525% +0.6905% +1.3823%]

Found 7 outliers among 100 measurements (7.00%)
  3 (3.00%) low mild
  1 (1.00%) high mild
  3 (3.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 102.8 ± 16.4 90.6 148.1 1.00
neqo msquic reno on 213.3 ± 9.8 202.6 235.9 1.00
neqo msquic reno 215.3 ± 12.4 203.8 237.8 1.00
neqo msquic cubic on 215.8 ± 9.9 202.4 234.3 1.00
neqo msquic cubic 217.4 ± 11.2 202.9 233.6 1.00
msquic neqo reno on 88.3 ± 8.8 82.9 114.7 1.00
msquic neqo reno 90.7 ± 9.8 83.0 110.8 1.00
msquic neqo cubic on 91.2 ± 12.3 80.6 129.0 1.00
msquic neqo cubic 103.0 ± 27.9 81.9 180.0 1.00
neqo neqo reno on 177.8 ± 63.7 130.1 382.4 1.00
neqo neqo reno 155.9 ± 26.8 125.3 240.4 1.00
neqo neqo cubic on 209.4 ± 119.2 138.6 579.5 1.00
neqo neqo cubic 204.8 ± 77.0 123.7 415.3 1.00

:arrow_down: Download logs