search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.85k stars 124 forks source link

ci: Fix Firefox build on Windows #2109

Closed larseggert closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.32%. Comparing base (2ca29c1) to head (7d84745). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2109 +/- ## ========================================== - Coverage 95.35% 95.32% -0.04% ========================================== Files 112 112 Lines 36325 36325 ========================================== - Hits 34638 34625 -13 - Misses 1687 1700 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

github-actions[bot] commented 2 months ago

Benchmark results

Performance differences relative to d4978debe744a3099eb8f854e1cacc2c1ec4e21e.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.153 ns 99.464 ns 99.776 ns]
       change: [-0.4491% +0.0285% +0.5908%] (p = 0.92 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
  10 (10.00%) high mild
  3 (3.00%) high severe
coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.13 ns 117.60 ns 118.21 ns]
       change: [-0.7897% -0.0799% +0.6241%] (p = 0.83 > 0.05)

Found 17 outliers among 100 measurements (17.00%)
  3 (3.00%) low severe
  1 (1.00%) low mild
  3 (3.00%) high mild
  10 (10.00%) high severe
coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.49 ns 116.80 ns 117.23 ns]
       change: [-1.1471% -0.4942% +0.0420%] (p = 0.11 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
  3 (3.00%) low severe
  2 (2.00%) low mild
  2 (2.00%) high mild
  3 (3.00%) high severe
coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.511 ns 97.644 ns 97.794 ns]
       change: [-0.5305% +0.2588% +1.1048%] (p = 0.54 > 0.05)

Found 8 outliers among 100 measurements (8.00%)
  4 (4.00%) high mild
  4 (4.00%) high severe
RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.29 ms 111.35 ms 111.42 ms]
       change: [-0.7239% -0.5192% -0.3843%] (p = 0.00 < 0.05)

Found 29 outliers among 100 measurements (29.00%)
  8 (8.00%) low severe
  2 (2.00%) low mild
  8 (8.00%) high mild
  11 (11.00%) high severe
transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [27.232 ms 28.140 ms 29.042 ms]
       change: [-6.2952% -1.8065% +3.2323%] (p = 0.48 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) low mild
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [35.479 ms 37.057 ms 38.668 ms]
       change: [-7.8850% -2.3048% +3.1796%] (p = 0.44 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold.
       time:   [31.103 ms 32.045 ms 32.916 ms]
       change: [-7.6922% -4.2224% -0.6214%] (p = 0.02 < 0.05)

Found 4 outliers among 100 measurements (4.00%)
  1 (1.00%) low severe
  3 (3.00%) low mild
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [40.143 ms 42.806 ms 45.462 ms]
       change: [-1.7874% +8.3894% +20.656%] (p = 0.12 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: :broken_heart: Performance has regressed.
       time:   [114.58 ms 115.08 ms 115.55 ms]
       thrpt:  [865.42 MiB/s 868.99 MiB/s 872.74 MiB/s]
change:
       time:   [+1.1596% +1.7243% +2.2736%] (p = 0.00 < 0.05)
       thrpt:  [-2.2230% -1.6951% -1.1463%]

Found 7 outliers among 100 measurements (7.00%)
  1 (1.00%) low severe
  4 (4.00%) low mild
  2 (2.00%) high mild
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [315.84 ms 319.35 ms 322.81 ms]
       thrpt:  [30.978 Kelem/s 31.314 Kelem/s 31.662 Kelem/s]
change:
       time:   [-0.0794% +1.5415% +3.1100%] (p = 0.06 > 0.05)
       thrpt:  [-3.0162% -1.5181% +0.0795%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [33.641 ms 33.845 ms 34.071 ms]
       thrpt:  [29.351  elem/s 29.546  elem/s 29.725  elem/s]
change:
       time:   [-1.1920% -0.4378% +0.3387%] (p = 0.29 > 0.05)
       thrpt:  [-0.3376% +0.4398% +1.2064%]

Found 5 outliers among 100 measurements (5.00%)
  5 (5.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 99.1 ± 9.8 89.7 127.4 1.00
neqo msquic reno on 211.7 ± 8.7 203.5 230.9 1.00
neqo msquic reno 215.5 ± 12.4 200.9 239.4 1.00
neqo msquic cubic on 216.4 ± 12.3 204.9 237.1 1.00
neqo msquic cubic 217.8 ± 12.7 204.4 234.4 1.00
msquic neqo reno on 89.8 ± 15.0 81.3 146.9 1.00
msquic neqo reno 100.4 ± 20.8 79.6 153.5 1.00
msquic neqo cubic on 96.3 ± 19.8 81.6 169.8 1.00
msquic neqo cubic 105.7 ± 27.9 80.3 170.4 1.00
neqo neqo reno on 150.4 ± 20.2 121.4 183.0 1.00
neqo neqo reno 168.5 ± 79.5 128.4 403.9 1.00
neqo neqo cubic on 177.3 ± 66.4 129.3 375.0 1.00
neqo neqo cubic 188.3 ± 69.0 124.3 384.5 1.00

:arrow_down: Download logs

github-actions[bot] commented 2 months ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.