search

mozilla / network-pulse

A stream of assets from peers across the Mozilla Network
https://mozillapulse.org
38 stars 41 forks source link

Missing Icon for Personal Site on profile #1150

Closed jgmac1106 closed 5 years ago

jgmac1106 commented 5 years ago

Describe the bug If you add your url in the profile edit page it does not add it to your profile,

To Reproduce Steps to reproduce the behavior: Add an a url, look at your profile. I see a glphy for github, twitter, and linkedin but none for a personal site.

Expected behavior Add a glyph either rss icon or a globe for a personal website....I prefer an rss icon but you know how semantic folks can get so a globe is fine as well.

jgmac1106 commented 5 years ago

I do see it on my actual profile page so maybe it is a matter of the Open Leaders(x) building profiles without the url. Not sure if that is a different repo and this one is just for Pulse core.

If so close and delete.

gideonthomas commented 5 years ago

Hi @jgmac1106 if you are referring to your image on https://foundation.mozilla.org/en/opportunity/mozilla-open-leaders/open-leaders-x/participants/#open-educational-resources-oer, the data shown their is meant to be optimal for viewing in a list. If you click on it (or your name), you are taken to your profile on pulse where you can see your personal website link. This profile page on pulse is where people can learn more about you and how to contact you. The page on OLx is meant to simply briefly list people participating in the program.

Feel free to reopen if I misunderstood your ticket.

jgmac1106 commented 5 years ago

Sounds good. Just a personal preference to share my own url before twitter's if I had to choose one. Keep issue closed.

On Wed, Sep 4, 2019 at 2:51 PM Gideon Thomas notifications@github.com wrote:

Hi @jgmac1106 https://github.com/jgmac1106 if you are referring to your image on https://foundation.mozilla.org/en/opportunity/mozilla-open-leaders/open-leaders-x/participants/#open-educational-resources-oer, the data shown their is meant to be optimal for viewing in a list. If you click on it (or your name), you are taken to your profile on pulse where you can see your personal website link. This profile page on pulse is where people can learn more about you and how to contact you. The page on OLx is meant to simply briefly list people participating in the program.

Feel free to reopen if I misunderstood your ticket.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mozilla/network-pulse/issues/1150?email_source=notifications&email_token=ACQL5JXS62Q3YLZMIYZ3HCDQH77R5A5CNFSM4ITKNKMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD54S4MQ#issuecomment-528035378, or mute the thread https://github.com/notifications/unsubscribe-auth/ACQL5JXM7NJG24OCDK6SUGLQH77R5ANCNFSM4ITKNKMA .

-- J. Gregory McVerry, PhD Assistant Professor Southern Connecticut State University twitter: jgmac1106