Closed kristinashu closed 7 years ago
Yep. Great idea. Useful for search as well.
is this enhancement applicable for issues tab or for all the relevant tabs. Please clarify. @xmatthewx @kristinashu
Only in the Issues tab, thanks!
Note that search results already does this (example), please style it the same.
Thanks @kristinashu . I added some code. Please, suggest should I add additional filters in order to restrict that to issue page or keep as it is.
@xmatthewx @mmmavis please suggest.
Yes, please hide on Featured and Latest pages. Thanks!
👍 Yes. Please hide everywhere. Everywhere but individual issue pages. It could also show on individual tag views, for example: /tags/mozfest. But it shouldn't appear anywhere else.
I have added following code:
reIssueCountResult() {
if(this.props.latest) return null;
if(this.props.featured || this.props.search || this.state.loadingData) return null;
let total = this.state.totalMatched,
plural = (total === 0 || total > 1), // because "0 results"
issueCountResult = `${total} result${plural ? `s` : ``} found`;
return <p>{issueCountResult}</p>;
},
Even though I added filter for latest tab, not sure why the count is still there.
@xmatthewx @mmmavis please assist.
@Sudip7 which file(s) were you working on / adding the above code to?
@Sudip7 do you wanna start a PR so I can check out your code and modified files?
@mmmavis , I have changed only one file, project-loader.jsx
. M sending the PR
@mmmavis any suggestions on fixing the problem??
Oops, this is done. Forgot to close this ticket.
@xmatthewx would you be up for adding something like this? This will be helpful feedback for users when one post appears at the top of several issues.
https://redpen.io/qf3e141d69fb01cf4c