Create client side "edit profile" view

mozilla / network-pulse

A stream of assets from peers across the Mozilla Network

https://mozillapulse.org

36 stars 41 forks source link

Create client side "edit profile" view #626

Closed alanmoo closed 6 years ago

xmatthewx commented 7 years ago

comp: https://redpen.io/bk7c2a3cbaafdcd47a

profile view lives at: /user/[id]

[x] display profile on success
[x] display errors on failure
[x] validate URLs
[x] TBD country validation
[x] 140 limit on bio char count (https://github.com/mozilla/network-pulse/issues/493 as prereq)
[x] responsive
[ ] pulls name from google account
[x] user can edit via link on their profile view
[x] nobody else can edit
[x] checklists can be existing mvp style
[ ] all fields are optional

xmatthewx commented 7 years ago

We likely wouldn't share with the public without Country validation if we believe we're going to do that. Hide behind feature flag.

mmmavis commented 6 years ago

Work has been merged to the feature branch. Up for @xmatthewx do decide if we are good to close this ticket.

xmatthewx commented 6 years ago

Hold the phone. The API might be down. @alanmoo is investigating.

Edit: I'm deleting my comments above. They are no longer relevant since are no longer broken.

alanmoo commented 6 years ago

https://network-pulse-staging-pr-691.herokuapp.com/myprofile works again

xmatthewx commented 6 years ago

This is looking good.

One thing I noticed ... but we can probably file as a follow up .... my profiled defaulted to name from google (that's good), but when i edit my profile, name field is blank. this is not terrible, but odd for the user to retype their name.

mmmavis commented 6 years ago

@xmatthewx Let's file a new ticket for that. Since edit form is working... can we close this ticket now?

xmatthewx commented 6 years ago

Yes! This is a big one! You want to have the joy if hitting the button? 💥💥💥💥

mmmavis commented 6 years ago

Implemented as part of PR https://github.com/mozilla/network-pulse/pull/691 🎉