mozilla / network-pulse

A stream of assets from peers across the Mozilla Network
https://mozillapulse.org
38 stars 41 forks source link

Default [name] to show on my profile page #687

Closed mmmavis closed 7 years ago

mmmavis commented 7 years ago

Comp: https://redpen.io/xy10b353c284b04a34 Alan Davidson is the name field we wanna discuss here.

When this person Alan Davidson visits his profile for the first time, what name do we wanna show there? @gideonthomas could you help list all the name fields that we are storing in the backend?

I don't know much about the design or backend infrastructure for profile page for organization. Is it another scenario we wanna include here?

/cc @xmatthewx @kristinashu

xmatthewx commented 7 years ago

My thinking (might be naive) was that...

Please feel free to debate these assumptions. Forgive blunders. Let me know if anything is unclear or ambiguous.

cc @gideonthomas

gideonthomas commented 7 years ago

All sounds good. Two things that still need to be done - Profile doesn't have a name, but a custom_name which isn't automatically set to User.name the first time the user logs in (yet), and, it looks like a profile isn't automatically created when a user logs in (though I might be wrong about that).

xmatthewx commented 7 years ago

Is this still blocked? Should we move to Up Next?

mmmavis commented 7 years ago

Currently front end shows Profile.custom_name if it exists in the Profile, else it falls back to Profile.name. If this is the intended behaviour we can close this ticket :)

xmatthewx commented 7 years ago

That sounds right to me! I'm going to start a ticket with a QA checklist to make sure test this.