search

mozilla / newnewtab

New Tab page: content server and recommendation service
https://wiki.mozilla.org/Apps/newnewtab
6 stars 5 forks source link

Newdev #36

Closed mzhilyaev closed 12 years ago

mzhilyaev commented 12 years ago

fixed Mardak's code-style siiues

tofumatt commented 12 years ago

I don't know what this code is supposed to be doing; I can't quite get a gist of what this pull request is for, exactly. Is it a cleanup branch or adding/removing functionality?

mzhilyaev commented 12 years ago

tofumatt, yes the abbreviations are known to mean ComponentServices, CompontentINterfaces, etc For the branch - it's an addon checkin The intial checkin was not very clean, hence, all the cleanup comments and subsequent changes appear

Mardak commented 12 years ago

Max, next time you'll want to make sure independent changes end up on their own branches instead of combining new changes into an existing pull request. I'll merge this in now if tofumatt agrees. We already have various followup issues filed. I'll also clean up the styling to better match other Mozilla code.