search

mozilla / newnewtab

New Tab page: content server and recommendation service
https://wiki.mozilla.org/Apps/newnewtab
6 stars 5 forks source link

fixed "leverage rev_host grouping" issue #43

Closed mzhilyaev closed 12 years ago

mzhilyaev commented 12 years ago

fixed by using "group by rev_host" query instead of pulling each individual url from places

Mardak commented 12 years ago

Could you run some timing measurement to see if this changes performance much for the better or worse?

mzhilyaev commented 12 years ago

timing for addon loading

  1. Profile is being read first time info: query time 2614 info: number crunching time 4
  2. Profile is being read again - Firefox is loaded second time in a raw info: query time 140 info: number crunching time 5

It appears that simply reading places.sql is what takes the most time. When the file is buffered, query time is reduced by 20x

Mardak commented 12 years ago

What are the numbers before with individual urls and after with rev_host?

mzhilyaev commented 12 years ago

Disregard the data above. The new data here Before the rev_host change, the addon timing was this:

info: query completion 1757 info: number crunching 5

After rev_host implementation timing is this: info: query time 138 info: number crunching time 5

I no longer can reproduce time difference between fresh and cached porfile

Mardak commented 12 years ago

The timing looks good. This pull request has unnecessary changes though. Just take the d1763df commit and rebase it to master and don't include the timing commit.