search

mozilla / newtab-dev

Repo following gecko-dev for newtab development. No longer maintained.
Other
18 stars 10 forks source link

Send placesLinks on getInitialState instead of initializeGrid. #35

Closed emtwo closed 8 years ago

emtwo commented 8 years ago

I think we may not actually need initializeGrid() at all once we're done with changes. So I just wanted to group this with the initial state sent.

NewTab:GetInitialState is handled in newTab.js AND RemoteAboutNewTab.jsm because some stuff (e.g. window) is only accessible from newTab.js context and some (e.g. placesLinks) from RemoteAboutNewTab.jsm.

Does this look ok @oyiptong ?

oyiptong commented 8 years ago

r+

let's get rid of initializeGrid as well.