mozilla / nightlytt

Nightly Tester Tools
https://wiki.mozilla.org/Auto-tools/Automation_Development/Projects/Addons/NightlyTesterTools
Other
62 stars 37 forks source link

Port back code-changes from Utilu Nightly Tester Tools 3.7.1.1 #186

Closed UtiluMark closed 9 years ago

UtiluMark commented 9 years ago
whimboo commented 9 years ago

I like a lot of those changes but it's really nothing we can land. If you want to get your changes into the core code base of NTT we would appreciate that. But it should happen in smaller steps, and only those bits which would not conflict (like the change of the addon id).

UtiluMark commented 9 years ago

What would be the best approach to get the changes you like into the core code base of NTT?

whimboo commented 9 years ago

Hey, thanks for getting back to us and the interest to bring back your code changes into the main developer tree. So having a quick look at the list of changes I think that the following might be a good way to get it done:

Would that work for you?

UtiluMark commented 9 years ago

Thank you. I've created a new fork of NTT, and started to re-apply the changes one by one. I've just submitted a separate pull request #187 for the first change (Removal of unused files). Is this the way to go? Then I'll create separate pull requests for the remaining changes as well.

whimboo commented 9 years ago

Yes, that looks totally fine. Thanks!

whimboo commented 9 years ago

If you want to be assigned to this issue I would suggest that you join our team: https://github.com/orgs/mozilla/teams/firefox-automation-contributor

whimboo commented 9 years ago

I'm going to close this PR given that we don't want to take the full code changes at once. Instead lets file a new issue for tracking purposes.