search

mozilla / nightlytt

Nightly Tester Tools
https://wiki.mozilla.org/Auto-tools/Automation_Development/Projects/Addons/NightlyTesterTools
Other
61 stars 37 forks source link

Removed non-working image host AllYouCanUpload #191

Closed UtiluMark closed 8 years ago

UtiluMark commented 8 years ago

Part of #188

xabolcs commented 8 years ago

@UtiluMark, how does this relate to #49?

UtiluMark commented 8 years ago

@xabolcs In this PR the non-working image host AllYouCanUpload is removed, #49 is about the other image host ImageShack.

xabolcs commented 8 years ago

Thanks @UtiluMark!

Didn't tested yet.

I don't like the unrelated changes, but for now I could accept them knowing that it would be overwritten soon by fixing #49.

UtiluMark commented 8 years ago

@whimboo Please review and merge.

xabolcs commented 8 years ago

r+

whimboo commented 8 years ago

I would tend to say lets revert the www prefix removal. It's better to have listed the specific subdomain in case something will change on that host (which indeed may be very unlikely but lets be safe).

UtiluMark commented 8 years ago

@whimboo I removed the www prefix, because https://imageshack.us/ works, while https://www.imageshack.us/ produces an ssl_error_bad_cert_domain error. I know we currently use http and not https, but as soon as that changes, the www prefix will need to be removed anyway.

whimboo commented 8 years ago

Interesting. The cert is only valid for *.imageshack.com but not us. Looks like its a broken SSL configuration on their end. So lets get this in for now but in the future lets ensure to have a separate PR for that.

whimboo commented 8 years ago

Merged the PR as https://github.com/mozilla/nightlytt/commit/497220120678f574d317a4ac576c5c7fd4b46bb1. Thanks!