search

mozilla / nightlytt

Nightly Tester Tools
https://wiki.mozilla.org/Auto-tools/Automation_Development/Projects/Addons/NightlyTesterTools
Other
62 stars 37 forks source link

Add ja-JP locale #200

Closed Cai0407 closed 8 years ago

Cai0407 commented 9 years ago

Please add ja-JP locale.

xabolcs commented 9 years ago

Hi there!

Thanks for contributing! Let's postpone reviewing (and landing) this PR for a few commits. There are pending string changes in the PR list.

Cai0407 commented 9 years ago

@xabolcs I see. I will wait for the completion of string changes.

whimboo commented 9 years ago

I think we can continue here given that all? necessary changes have been landed meanwhile? @xabolcs can you please check?

xabolcs commented 8 years ago

It would be nice to land #93 and #137 before reviewing this.

UtiluMark commented 8 years ago

188 will also add a few strings to the translation files.

Cai0407 commented 8 years ago

Version 3.8 seems to be released soon. Can I resume update of ja-JP locale now?

UtiluMark commented 8 years ago

Note: pending issue #188 will add a few new strings to the translation files.

xabolcs commented 8 years ago

@whimboo, it would be nice to clarify what to ship with 3.9 release and let @Cai0407 resume update of ja-JP locale.

whimboo commented 8 years ago

@xabolcs, I wouldn't add too much for a new release. It would be better to release more often instead. So I only moved all not-fixed-yet issues from 3.8 to 3.9. Also I think we shouldn't wait to long for localizers to update their locale. They should be able to do it at any time, but may have to do it again in case something else gets changed soon after.

I'm happy to get this merged after we proofed the correctness of the strings.

Cai0407 commented 8 years ago

I have created revised PR #226.

whimboo commented 8 years ago

There is usually no need to create a new PR. In case of conflicts those need to be resolved locally and force pushed to your remote branch. For this time lets continue on PR #226.