mozilla / nightlytt

Nightly Tester Tools
https://wiki.mozilla.org/Auto-tools/Automation_Development/Projects/Addons/NightlyTesterTools
Other
62 stars 37 forks source link

Release version 3.8 (#207) #208

Closed whimboo closed 8 years ago

whimboo commented 8 years ago

This PR is the fix for issue #207 and adds the history changes and bumps the version number.

@xabolcs can you please review? Thanks

UtiluMark commented 8 years ago

Shouldn't Seamonkey's maxVersion be 2.48 instead of 2.40?

UtiluMark commented 8 years ago

Notes on the changelog:

tonymec commented 8 years ago

FWIW:

whimboo commented 8 years ago

In previous versions each line was indented with two spaces " ", but the 3.8 changes are indented with only one space " ".

We should better correct the older entries as continuing with two spaces.

In previous versions each line was prefixed with either "Repository: " or "Extension: ", but the 3.8 changes don't have prefixes.

I feel this is obsolete information given that most changes will affect the extension. We could save us from this hand-crufting additions for each version by specifying explicitly if a change was done to the repository, and remove all 'Extension' prefixes. Does that sound ok?

"Release version 3.8 (#207)" isn't worth mentioning in the history of changes I think, none earlier version has a similar release line. "Update minVersions for applications (#207)" would be worth mentioning.

Ok, I will update this line so we mention the min version bump.

Also thanks for pointing out the current to hopefully be released version of SeaMonkey.

I will update the PR once we reached consensus about the prefixes.

xabolcs commented 8 years ago

We should better correct the older entries as continuing with two spaces.

I'm OK with changing the old entries.

I feel this is obsolete information given that most changes will affect the extension. We could save us from this hand-crufting additions for each version by specifying explicitly if a change was done to the repository, and remove all 'Extension' prefixes. Does that sound ok?

It's OK to me to remove all the Extension: prefixes.

whimboo commented 8 years ago

I pushed an update for this PR. So please check again. Thanks.

xabolcs commented 8 years ago

Thanks! Looks good, only one note about .editorconfig. See inline comment!

whimboo commented 8 years ago

An update has been pushed. Will land the patch now.