Consider making "channel" optional in NimbusExperiment schema

mozilla / nimbus-shared

Shared data and schemas for Project Nimbus

https://mozilla.github.io/nimbus-shared

Mozilla Public License 2.0

5 stars 15 forks source link

Consider making "channel" optional in NimbusExperiment schema #125

Closed rfk closed 3 years ago

rfk commented 3 years ago

The channel property is currently required to be an array of strings. Some applications (e.g. reference-browser) may not have a useful notion of channels, and it's not obvious what we should put in that field in that case. Setting it to an empty array risks being interpreted as "don't run in any channels".

rfk commented 3 years ago

For completeness, noting that IIUC the example in https://github.com/k88hudson/nimbus-shared/blob/fd5a6eaa321086edbefff123c388a3151b26a58f/data/experiment-recipe-samples/mobile-a-a.json doesn't validate against the current schema because it doesn't have the "channels" field.

k88hudson commented 3 years ago

Sorry for the incorrect references here – this was actually fixed by https://github.com/mozilla/nimbus-shared/commit/fb38808b0ae6e6f84e0a74e9592156ea73e595a9. I decided to remove channel as a top-level property until we can sort out some complexity around unbranded builds etc.