search

mozilla / nimbus-shared

Shared data and schemas for Project Nimbus
https://mozilla.github.io/nimbus-shared
Mozilla Public License 2.0
6 stars 15 forks source link

Add outcomes to DTO #159

Closed tdsmith closed 3 years ago

tdsmith commented 3 years ago

Alternatives here are:

I think using an array of objects is more flexible in case we want to add more annotations later but maybe YAGNI. The use case I'm envisioning is letting someone identify all the experiments that had a given outcome as a primary outcome.

jaredlockhart commented 3 years ago

Oh yeah good point, we should rename that to 'outcomes', and I think just being an array of slugs should be sufficient since that's all jetstream needs because it has the rest of the metadata available by querying directly from jetstream-config.

jaredlockhart commented 3 years ago

Oh I see you want to include the primary/secondary designation. Yep that looks good too. Not sure if strings is the right way to do it, rather than just a bool for is_primary. Depends on if we ever want to have a third category. If we use the strings then we need to make sure they're the same everywhere, ie in experimenter/jetstream. Not hard for two constants but just something to be aware of.

tdsmith commented 3 years ago

I guess the other thing to call out is that I intend to tag this as 1.4.0 after it's merged.