Closed lmorchard closed 2 years ago
Kind of winging it on the example files as my first try. Let's see what I missed!
Seeing all the comments on the example data in this PR, it seems maybe worth backing up and seeing if we have a better source for these?
Maybe @heres-maria has a better way to come up with this sample data? That is - come up what is actually useful for testing these things, put that in this PR.
My goal was just to set isRollout: true
with the rest of the experiment being unremarkable. Most of the rest of the properties are copied over from other data files in this repo, but it sounds like those are problematic also?
Seeing all the comments on the example data in this PR, it seems maybe worth backing up and seeing if we have a better source for these?
Maybe @heres-maria has a better way to come up with this sample data? That is - come up what is actually useful for testing these things, put that in this PR.
My goal was just to set
isRollout: true
with the rest of the experiment being unremarkable. Most of the rest of the properties are copied over from other data files in this repo, but it sounds like those are problematic also?
@lmorchard For the feature part at least, maybe these production experiments can be used as the starting point for the iOS and Fenix recipes? They are current "rollouts". https://experimenter.services.mozilla.com/nimbus/all-users-homescreen-ios-production https://experimenter.services.mozilla.com/nimbus/all-users-home-screen-android-production
Alright, maybe third try's the charm? Rebased off main, copied the multifeature example data files, changed some names and added "isRollout": true
to them along with adjusting the bucket namespace. Not sure what else needs doing?
Revised this PR to drop the sample data. The schema change here is very small, but the testing data blocking merge of the PR seems to have been a moving target that I don't have the context to assemble properly.
Maybe we should just add the sample data after successful testing? That way we record what was used rather than trying to guess what might work?
Missed the thumbs up earlier, just going to merge this and we can move on with sample data when we have it
Possible testing data: Desktop:
Firefox Android:
Firefox iOS:
Because:
This commit:
adds an isRollout boolean to the NimbusExperiment type
introduces example recipes for both mobile and desktop for testing