search

mozilla / nimbus-shared

Shared data and schemas for Project Nimbus
https://mozilla.github.io/nimbus-shared
Mozilla Public License 2.0
5 stars 15 forks source link

Remove schemaVersion from test recipes #186

Open jaredlockhart opened 2 years ago

jaredlockhart commented 2 years ago

Since the schemaVersion in test recipes will not be known when test data is written, anything we write in that field will be wrong, so maybe we should omit it from the test recipes altogether? We need to verify that clients don't depend on that field in any way first.

lmorchard commented 2 years ago

Looks like schemaVersion is required by the NimbueExperiment type, so when I tried removing it from the example data in my PR, the CI run failed.

Easy fix would be to make it optional in the type along with taking it out of example data, but that goes back to the verifying that clients don't depend on the field.