Closed jaredlockhart closed 2 years ago
For Jetstream to perform an experiment analysis, it uses the enrollment period to determine which clients to include in its analysis. When an experiment is launched it includes a proposed enrollment period, and that can be used to compute a proposed enrollment end date, however many experiment timelines deviate from their proposed timelines and so the actual enrollment end date may not match the proposed enrollment end date. For Jetstream to know the actual enrollment end date, we have to include it in the publicly accessible experiment definition and so we should add an enrollmentEndDate: string
field to the experiment type.
Related change in the Experimenter API: https://github.com/mozilla/experimenter/issues/7410
Welcome Change Captain! ⛵️
When making schema changes, follow this guidance to avoid breaking changes:
Rather than modifying an existing field, consider adding a new field with a new name and later deprecating the old field when it is no longer used
When deprecating an existing field, consider making it optional/nullable rather than removing it altogether and then removing it entirely when all clients/active experiments no longer depend on it
Proposing Schema Changes
When Client Changes Are Complete
When Client QA is Complete
When Bugs Are Resolved and Clients Are Released
[ ] Comment below indicating which version of each client application includes the changes
[ ] File tickets/epics in Nimbus Engineering to implement the changes in Experimenter and add them in a comment below, including:
[ ] File tickets/epics in Jetstream to adapt it to any incoming changes that affect its analysis
When Experimenter Changes Are Complete