Closed brennie closed 2 years ago
The filter_expression has not been used since at least April 2020, see https://github.com/mozilla/messaging-system-inflight-assets/issues/41 and https://github.com/mozilla/messaging-system-inflight-assets/pull/39#discussion_r416725007 for details.
I talked to @jaredlockhart about this and since this field has not been in use for years, there really isn't a reason to go through with the entire process, we can instead just remove the field.
Welcome Change Captain! ⛵️
When making schema changes, follow this guidance to avoid breaking changes:
Rather than modifying an existing field, consider adding a new field with a new name and later deprecating the old field when it is no longer used
When deprecating an existing field, consider making it optional/nullable rather than removing it altogether and then removing it entirely when all clients/active experiments no longer depend on it
Proposing Schema Changes
When Client Changes Are Complete
When Client QA is Complete
When Bugs Are Resolved and Clients Are Released
[ ] Comment below indicating which version of each client application includes the changes
[ ] File tickets/epics in Nimbus Engineering to implement the changes in Experimenter and add them in a comment below, including:
[ ] File tickets/epics in Jetstream to adapt it to any incoming changes that affect its analysis
When Experimenter Changes Are Complete