search

mozilla / nixpkgs-mozilla

Mozilla overlay for Nixpkgs.
MIT License
527 stars 129 forks source link

Replace deprecated stdenv.lib with lib #250

Closed andersk closed 3 years ago

andersk commented 3 years ago

Fixes this message in NixOS 21.05:

trace: Warning: `stdenv.lib` is deprecated and will be removed in the next release. Please use `lib` instead. For more information see https://github.com/NixOS/nixpkgs/issues/108938

See NixOS/nixpkgs#108938.

(In case you’re worried about backwards compatibility: lib and stdenv.lib have both been there since 2007, with lib being a few commits older.)

andersk commented 3 years ago

See also NixOS/nixpkgs#111284, which specifically notes that stdenv.lib will be removed in NixOS 21.11. I assume this will happen in nixpkgs-unstable not long after 21.05 is branched.

bkchr commented 3 years ago

@nbp can we get this merged?

leo60228 commented 3 years ago

21.05 released on May 31st, so this is now an issue for people on NixOS stable as well.

oppiliappan commented 3 years ago

A quick temporary fix is to replace the URL to nixpkgs-mozilla with @andersk's fork:

mozillapkgs = {
   url = "github.com:andersk/nixpkgs-mozilla/stdenv.lib";
   flake = false;
}
andersk commented 3 years ago

stdenv.lib has now actually been removed (NixOS/nixpkgs#125494), leading to fatal errors in nixos-unstable.

error: attribute 'lib' missing, at …/nixpkgs-mozilla/rust-overlay.nix:296:30

@nbp Please merge this.

attente commented 3 years ago

Is there a reason this PR hasn't been merged? I skimmed through the changes and am using the branch personally, so I'm wondering if there's another reason preventing it.

Artturin commented 3 years ago

@rail

Slabity commented 3 years ago

@nbp - Can you please take a look at this and merge if possible? The overlay is broken in its current state.