search

mozilla / nixpkgs-mozilla

Mozilla overlay for Nixpkgs.
MIT License
517 stars 128 forks source link

Should git-cinnabar be included into firefox development overlay? #276

Open kvark opened 2 years ago

kvark commented 2 years ago

git cinnabar is required by ./mach try commands, so I'd argue that it should be included by default.

kvark commented 2 years ago

Also, less is expected by default by git, so we should include that.

nbp commented 2 years ago

I am open to both, the problem I see with this approach is that mach might try to be clever based on programs which are installed, such as downloading the source code or using a tool even if it does not match the fetched source.

What I used to do is to start a nix-shell without the --pure argument, to use the tool which is provided in the environment.

Either sounds fine to me.