applicationName is now binaryName in upstream firefox

marcenuc commented 2 years ago

I have been using this patch for a couple of days to get firefox nightly working in NixOS with the nixpkgs-unstable channel.

The error is the same as in #262, but I think it is related to https://github.com/NixOS/nixpkgs/pull/165161/files.

This is the snippet of /etc/nixos/configuration.nix that I am using:

{ config, pkgs, ... }:
{ # ...
  nixpkgs.config.allowUnfree = true;
  nixpkgs.overlays =
    let
      moz-rev = "master";
      moz-url = builtins.fetchTarball { url = "https://github.com/marcenuc/nixpkgs-mozilla/archive/${moz-rev}.tar.gz";};
      nightlyOverlay = (import "${moz-url}/firefox-overlay.nix");
    in [
      nightlyOverlay
    ];
  environment.systemPackages = with pkgs; [
    latest.firefox-nightly-bin
    # ...
  ];
  # ...
}

Artturin commented 2 years ago

https://github.com/mozilla/nixpkgs-mozilla/pull/289

marcenuc commented 2 years ago

@Artturin Sorry for the duplicate! I searched for it but, somehow, I failed to find it.

I see that your patch is different. But I'm new to Nix, and then I do not know if your fix is better than mine. Do you have any suggestions?

marcenuc commented 2 years ago

Closing because #284 fixes it.

mozilla / nixpkgs-mozilla

applicationName is now binaryName in upstream firefox #290