search

mozilla / nixpkgs-mozilla

Mozilla overlay for Nixpkgs.
MIT License
516 stars 128 forks source link

rust-overlay: restore SYSROOT detection for Darwin #309

Open ggreif opened 1 year ago

ggreif commented 1 year ago

f6fe8508b0910b84b74c0e0bfa0ff8593e77d470 broke Darwin (fixes #304). This PR:

Takes some cues from #306 (and supersedes it).

AliSajid commented 1 year ago

Bump for attention.

nbp commented 1 year ago

Bump for attention.

Unfortunately, this does not work this way … You can always ping me on https://matrix.to/#/#mozilla:nixos.org .

ggreif commented 1 year ago

Looks like #304 has fixed this, so closing for now.

ggreif commented 1 year ago

Unfortunately .dylibs are not considered in #304 yet, so reopening.

ggreif commented 1 year ago

@AliSajid I am using this branch as pull/309/head and it works for both Linux and Darwin in our setup.

ggreif commented 1 year ago

@Artturin @nbp This is now a very mild delta, any chance to review?