search

mozilla / node-client-sessions

secure sessions stored in cookies
Mozilla Public License 2.0
759 stars 104 forks source link

Is this project mantained? #106

Closed 0m15 closed 7 years ago

0m15 commented 9 years ago

Please give some details about the topic, as it seems that the library is completely broken on latest Express version (4.3.13), also as reported on #105

ponelat commented 8 years ago

seems to be working on my setup... express@4.13.3 what exactly is your issue?

Mithgol commented 8 years ago

This module also works for me on Express.js version 4.13.1 (which is not exactly 4.13.3, but the differences are minimal and shouldn't affect sessions).

However, I don't use Passport as in #105; I just do the following:

app.use(sessions({
   cookieName: 'XXXXX', // the key name added to the request object
   secret: 'YYYYYYYYYYYYYYYY', // a large unguessable string
   duration: 1000 * 60 * 60 * 10, // 10hr: how long a session stays valid
   activeDuration: 1000 * 60 * 15 // 15min: if expiresIn < activeDuration,
                                // a session is extended by activeDuration
}));

(of course, some real values are used instead of XXX and YYY but they should stay secret).

atnmorrison commented 7 years ago

I'm also wondering if I should look for something else, it doesn't look like the source code has been touched for several years other than updating the readme, and it's still at version 0.7 has it been abandoned?

seanmonstar commented 7 years ago

We don't spend much time actively working on this library, but that's in part because it does all we need. We used it extensively in Persona, but use a different authentication strategy entirely in Firefox Accounts. Not because this is bad, but we just had different needs. The minor services we have that still use this haven't had a need for changes, so we haven't made changes.

If there is a bug, a PR is always welcome!