Support same site cookie flag

mozilla / node-client-sessions

secure sessions stored in cookies

Mozilla Public License 2.0

759 stars 105 forks source link

Support same site cookie flag #121

Closed busticated closed 7 years ago

busticated commented 7 years ago

hi there :wave:

thanks for a very helpful lib. i get the impression it's between owners at the moment but i figured i'd open this anyway. my aim here was to gain support for the sameSite cookie flag [info] [spec] available in chrome v51+ and others. i ended up upgrading the test dependencies along the way. happy to make adjustments :+1:

-matt

seanmonstar commented 7 years ago

Looks good to me! I've updated travis to run tests on newer node versions, and this PR passes with it, so a merge should take care of it all. Thanks!

busticated commented 7 years ago

@seanmonstar oh nice - thanks! fwiw, i actually had a fix in-flight locally for the hung tests - the server instances are never closed and as such vows never exits (though tests all pass). for the most part, you just need to expose the underlying server instance returned by listen() + add teardown handlers for each topic to call .close().

it might actually be easier to migrate over to something like mocha though.

anyway, if any of that would be helpful, let me know!