search

mozilla / node-client-sessions

secure sessions stored in cookies
Mozilla Public License 2.0
759 stars 104 forks source link

secureProxy is deprecated in cookies #132

Open robsquires opened 6 years ago

robsquires commented 6 years ago

The secureProxy option has been deprecated by the cookie module when it is passed as a cookie option during cookies.set(). The module recommends passing the secureProxy option in the constructor instead.

https://github.com/pillarjs/cookies/commit/c7cf922795020bcfd284103d5c8ad792d4261699

This PR implements that recommendation.

kelsin commented 6 years ago

Any word on getting this merged in?

DarylPinto commented 4 years ago

@vladikoff Please consider merging this PR. Without it production node apps that run behind a proxy like nginx (which is most of them), cannot make use of the secure flag. I know this library isn't being maintained anymore, but please consider merging in PRs that prevent deprecation.