search

mozilla / node-convict

Featureful configuration management library for Node.js
Other
2.34k stars 146 forks source link

Fix typo #375

Closed xamgore closed 4 years ago

xamgore commented 4 years ago

https://www.npmjs.com/package/json5#json5parse

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 93.37% when pulling 540c4d12ef71bac4641a60ea6870d72bc1e11d0f on xamgore:patch-1 into eb2db0c49d003fdd2c5974973d803ecf20b4fb16 on mozilla:master.

madarche commented 4 years ago

What you are proposing to modify is not a typo. Also the proposed change is not consistent with the overall code style. So, not accepting this PR.

madarche commented 4 years ago

So the typo is fixed. Thanks to @xamgore and @pdehaan!