search

mozilla / node-firefox

node.js modules for interacting with Firefox via the DevTools remote protocol
https://www.npmjs.org/package/firefox
Mozilla Public License 2.0
301 stars 18 forks source link

Closes #31 Create spell checking travis test suite #32

Closed erikvold closed 9 years ago

erikvold commented 9 years ago

@tofumatt r?

tofumatt commented 9 years ago

That is... very cool! :+1:

lmorchard commented 9 years ago

Small nitpick: The tests should have probably used nodeunit, since that's what we're using throughout the rest of the suite. (Though, I actually like mocha & chai better.)

tofumatt commented 9 years ago

Good point, I'll convert them over today.

-tofumatt On 11 Mar 2015 22:52, "Les Orchard" notifications@github.com wrote:

Small nitpick: The tests should have probably used nodeunit, since that's what we're using throughout the rest of the suite. (Though, I actually like mocha & chai better.)

— Reply to this email directly or view it on GitHub https://github.com/mozilla/node-firefox/pull/32#issuecomment-78390308.