mozilla / node-fx-runner

Node API to control Firefox
Mozilla Public License 2.0
12 stars 21 forks source link

`firefoxdeveloperedition` alias is long and named differently than the other aliases #43

Closed ariasuni closed 4 years ago

ariasuni commented 4 years ago

All aliases of non-release editions of Firefox are named after the part that goes after Firefox:

It follows that the alias for Firefox Developer Edition should be developer-edition. This would also make it more useful as an alias because it’s less text to type.

Rob--W commented 4 years ago

I propose "deved" as alias, because it is shorter and also commonly used by Mozillians.

What is your use case? Are you using this library directly, or is it affecting you elsewhere (e.g. in web-ext)?

ariasuni commented 4 years ago

Personally, it’s the first time I heard of deved and it sounds obscure.

What about dev-edition? Easy to understand, reasonably short.

ariasuni commented 4 years ago

Also I see that deved is not really used as is, it’s more DevEd and I can only found occurrences of it on obscure pages of Mozilla Wiki, while you the expression Dev Edition is used on https://www.mozilla.org/en-US/firefox/developer/.

Anyway if you still think deved is a better alias, then I’ll put that in my PR.

Rob--W commented 4 years ago

I've also seen DevEd on community-supported support forums such as Reddit (/r/firefox).

devedition sounds like a reasonable short alternative if you really have a feud against deved ;)

ariasuni commented 4 years ago

I don’t know, I feel like deved isn’t intuitive to remember. It’s very frequent to abbreviate developer to simply dev, not so much for edition.

If that was me, I’d run a very unscientific poll on social media to have an idea of what people prefer in term and shortness and memorability, to have a rough idea of how it might work for other people.

But maybe that’s just overthinking on my part for a detail.

ariasuni commented 4 years ago

Also, DevEd is easier to parse because of case, and default profile name for Dev Edition is «dev-edition-default».

Anyway, I don’t think there’s things I can add to this discussion and it’s been a week now so maybe we should just chose a name and be done with it. Just tell me what you’d prefer and I’ll update my PR so it can be merged.

Rob--W commented 4 years ago

I want at least one short name, deved or devedition.

It's a bit confusing to follow the discussion because it's split between this issue and the pull request (#44). The PR has not been updated despite the comments there: https://github.com/mozilla-jetpack/node-fx-runner/pull/44#issuecomment-611822805 . Please update the PR, then I'll review it.

ariasuni commented 4 years ago

Oh, sorry, I was waiting for a «final» decision before changing my PR, so I’m still not sure what I’m supposed to do.

Rob--W commented 4 years ago

Current PR + https://github.com/mozilla-jetpack/node-fx-runner/pull/44#issuecomment-614666904

I'm fine with "deved" or "devedition", as long as it is shorter than "firefoxdeveloperedition"