mozilla / normandy

Firefox recipe server
https://wiki.mozilla.org/Firefox/Recipe_Server
Mozilla Public License 2.0
55 stars 46 forks source link

Use a method instead of a property to determine capabilities for filter objects #2313

Closed mythmon closed 3 years ago

mythmon commented 3 years ago

The property name "capabilities" collided with the field "capabilities" for the JEXLFilterObject. Coincidentally this was ok, but it certainly was not the intended path. Changing to "get_capabilities" stops the collision, and it is unlikely to collide in the future. However, this points out a serious flaw in this way of definining filter objects.

bors[bot] commented 3 years ago

Build succeeded: