mozilla / normandy

Firefox recipe server
https://wiki.mozilla.org/Firefox/Recipe_Server
Mozilla Public License 2.0
55 stars 46 forks source link

Remove check about Remote Settings version #2333

Closed leplatrem closed 3 years ago

tiftran commented 3 years ago

bors merge

bors[bot] commented 3 years ago

Build failed:

tiftran commented 3 years ago

bors retry

bors[bot] commented 3 years ago

Build succeeded:

leplatrem commented 3 years ago

Looks good to be, but could we get a version for signer(I can create a github issue/bugzilla etc for a formal request)? If so, we could keep this check around, if version will be available again

We will probably restore that version field, but the string comparison was dumb (my fault :grimacing:) anyway.

I think the best way would be to rely no the server version directly, and not just the version of a plugin.