mozilla / nunjucks

A powerful templating engine with inheritance, asynchronous control, and more (jinja2 inspired)
https://mozilla.github.io/nunjucks/
BSD 2-Clause "Simplified" License
8.48k stars 635 forks source link

Remove dependency on `a-sync-waterfall` #1381

Open fspoettel opened 2 years ago

fspoettel commented 2 years ago

In light of recent supply chain attacks against the npm ecosystem, I examined the dependency graphs of my projects to identify risky downstream dependencies.

Nunjucks has few dependencies (which is great) but a-sync-waterfall stood out to me as a great attack target and I would propose to inline it into nunjucks to remove the dependency. My reasoning is the following:

In my view, the risk of depending on this package outweigh the benefits of not having to maintain the piece of code.

I'm happy to contribute a PR and help with this. Feel free to close the issue otherwise.