mozilla / nunjucks

A powerful templating engine with inheritance, asynchronous control, and more (jinja2 inspired)
https://mozilla.github.io/nunjucks/
BSD 2-Clause "Simplified" License
8.48k stars 634 forks source link

[Ready for review] Indent filter does not ignore empty lines #1425

Open NikolaDojic opened 1 year ago

NikolaDojic commented 1 year ago

Summary

Proposed change: https://github.com/mozilla/nunjucks/issues/1421#issue-1459826388 Closes #1421.

Checklist

I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.

codecov[bot] commented 1 year ago

Codecov Report

Base: 89.65% // Head: 89.66% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (364d825) compared to base (fd50090). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1425 +/- ## ======================================= Coverage 89.65% 89.66% ======================================= Files 22 22 Lines 3046 3047 +1 ======================================= + Hits 2731 2732 +1 Misses 315 315 ``` | [Impacted Files](https://codecov.io/gh/mozilla/nunjucks/pull/1425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [nunjucks/src/filters.js](https://codecov.io/gh/mozilla/nunjucks/pull/1425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#diff-bnVuanVja3Mvc3JjL2ZpbHRlcnMuanM=) | `96.27% <100.00%> (+0.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.