search

mozilla / observatory-cli

Mozilla Public License 2.0
189 stars 24 forks source link

Add Dockerfile and function to run it as executable #21

Closed jrm16020 closed 8 years ago

jrm16020 commented 8 years ago

The idea behind the shell functions is to include something like this in .bashrc

if [[ -d $HOME/.bash_functions ]]; then for file in $HOME/.bash_functions/*; do . $file done fi

gregglind commented 8 years ago

Hello! Newb to docker and such. please explain the (maybe obvious?) use case for all this? I has confused, but am educable!

jrm16020 commented 8 years ago

This comes specifically from the desire to include testing like this in a CI/CD pipeline. Having the observatory CLI tool in a container means that I don't have to add software to my Jenkins master or agent to execute Observatory; it only needs to be able to run containers.

A side benefit is that this would compliment the containerized http-observatory. If everything is in a container, I can get my developers to adopt its use by executing a few easy commands without installing extra software to their host operating system.

Does that help? I'm happy to prove further justification as needed.

jrm16020 commented 8 years ago

@gregglind I also added Bash completion to the PR.

gregglind commented 8 years ago

Thanks! I mostly wanted to make sure this was an enhancement that I had to do nothing for :) If it breaks, I will send them right to you :)

Thanks for the PR!

GL

jrm16020 commented 8 years ago

I'm happy to send it! We need more tools like this one!

gregglind commented 8 years ago

(npm package of 0.6.5 has this. A few bugs to fix for 0.7.0 though, maybe today or tomorrow)

gregglind commented 8 years ago

(sorry for another request... mind posting a little blurb here for the 'README' to describe docker mode / usage? Maybe it's obvious for Docker people :) )

see #22