search

mozilla / oghliner

template and tool for deploying Offline Web Apps to GitHub Pages
https://mozilla.github.io/oghliner/
Apache License 2.0
116 stars 17 forks source link

Run tests using 'stable' version of Node.js #239

Closed marco-c closed 8 years ago

marco-c commented 8 years ago

This way we notice when something breaks on new Node.js releases.

mykmelez commented 8 years ago

The pull request build passed, but the merge build failed, on both 0.12 and "stable":

0.12:

  1) CLI interface, oghliner as a template "after all" hook for "should work":
     Error: the string "no access token supplied" was thrown, throw an Error :)
      at tryCallOne (node_modules/promisify-node/node_modules/nodegit-promise/lib/core.js:37:12)
      at node_modules/promisify-node/node_modules/nodegit-promise/lib/core.js:103:15
      at flush (node_modules/promisify-node/node_modules/nodegit-promise/node_modules/asap/raw.js:50:29)

stable:

  1) CLI interface, oghliner as a template should work:
     Error: spawn node_modules/.bin/gulp ENOENT
      at exports._errnoException (util.js:856:11)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:179:32)
      at onErrorNT (internal/child_process.js:345:16)

I restarted the build, and it failed the same way the second time around on stable, although it passed on 0.12. Intermittent failure?

marco-c commented 8 years ago

Error: spawn node_modules/.bin/gulp ENOENT This is a weird error, looks like gulp wasn't installed.