search

mozilla / oghliner

template and tool for deploying Offline Web Apps to GitHub Pages
https://mozilla.github.io/oghliner/
Apache License 2.0
116 stars 17 forks source link

Make requests to directories become requests to index.html #254

Closed delapuente closed 8 years ago

delapuente commented 8 years ago

Fix #253

marco-c commented 8 years ago

The patch looks good to me, but I'd make this configurable. Were you planning to make it configurable in a follow-up?

delapuente commented 8 years ago

I was not planning to make it configurable as it is not configurable in gh-pages (it is always this way) but we can add a follow up and make it optional.

marco-c commented 8 years ago

Sounds good to me. Let's see what @mykmelez thinks, since he's been reviewing #234.

mykmelez commented 8 years ago

Let's see what @mykmelez thinks, since he's been reviewing #234.

I'm ok with this, as it's a useful, GitHub Pages-specific fix, while #234 is a more general solution for folks who reuse Oghliner on other hosts. And it sounds like @delapuente and @jonathanKingston are working together to move #234 forward as well.

delapuente commented 8 years ago

@mykmelez @marco-c I added your comments. Do you mind to take a second look?