Closed Verdi closed 7 years ago
Some of the font sizes mentioned are way to small and pose an accessibility issue. The light gray on white is to low contrast and again poses a11y issues.
With regards to the button on the right. This is clearly designed for people with large viewports and, looking at the general audience, it would make more sense to have the button below the copy from the start.
Thoughts?
"Progress Pill" and Welcome to Firefox
Notification Content:
Close button:
Only visible when the pointer is over the notification
Posted by @jenniferdavidson
@mart3ll @verdi Is it too late to ask for a new asset? I'm thinking it would be neat to include the private browsing raccoon face, instead of the emoji style face on the private browsing notification. What do you both think?
@schalkneethling
As we still need to get the GA things done and incorporated, we have some time but, it will depend on Sean's availability. Easy for me to update.
Posted by @jenniferdavidson
This one is for Michael. @verdi Can we add some fox icon or Firefox logo on the notification design? I'm just noticing that the only branding we have is the words 'Welcome to Firefox', and I'm wondering if we'll see the same issues as Onboarding v1.1 where the branding wasn't clear enough and participants weren't sure that it was actually Firefox serving up these notifications.
RC6: The height of the notification bar is 163px - should be 120px.
RC6: The "pill" and "Welcome to Firefox" is 245px from the left edge - should be 50px.
RC6: Drop "Welcome to Firefox" when it's closer than 50px to the notification icon to the right.
RC6: Everything in the notification should be centered vertically but it's not.
RC6: Icon, notification copy and button should be centered horizontally as a group but they're not.
RC6: Button is 48px high - should be 40px.
RC6: Button text should be Segoe UI Bold, 12px.
RC6: Button color should be #0094FB, border color should be #006ECF, and the radius should be 2px.
RC6: Please make the headline font smaller and reduce the bottom margin.
RC6: Close button should be 56px from the right; 50px for the hover version.
All other copy is sans-serif
and the standard across Mozilla(for now) is Open Sans so, wonder we should just use Open Sans instead of Segoe UI Bold? With that said, including a font for just one piece of copy is going to increase the size of the add-on, and I am not sure if the payoff is large enough. Thoughts?
So this is not supposed to be a web property, it's part of the product so I wanted to use system default fonts. Would we have to include Segoe UI? Wouldn't it be on the user's computer? We can use open sans as a fallback for the odd case where it fails for some reason. @pdolanjski are we going to have Windows XP in this test (they have a different default font)?
Would we have to include Segoe UI? Wouldn't it be on the user's computer?
If we feel confident enough that it would be on the users computer then no, I can just specify that, with a fallback to sans-serif
No Windows XP. XP users are now on the ESR 52 release and won't get future versions.
On Tue, Apr 11, 2017 at 11:23 AM, Schalk Neethling <notifications@github.com
wrote:
Would we have to include Segoe UI? Wouldn't it be on the user's computer?
If we feel confident enough that it would be on the users computer then no, I can just specify that, with a fallback to sans-serif
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mozilla/onboard/issues/46#issuecomment-293298667, or mute the thread https://github.com/notifications/unsubscribe-auth/AFFXg5velRj9ZT2sjp6p-SQd7jepubEnks5ru5rqgaJpZM4MyDxl .
Font change landed in https://github.com/mozilla/onboard/pull/88
Here's a few last tweaks:
@Verdi How does this look?
And on hover
Missed the bold of the copy on the button. I have added that locally.
Also, should we bump the font size and letter spacing a little now that it is bold?
Before
After
Almost there
@Verdi Here are a couple of screen shots. To make it as responsive as possible, I had to make a few calls here and there with regards to width, positioning etc. Let me know your thoughts.
Mainly the button needs to go in the same group as the icon and text and then that group gets centered.
Gotcha, seems like you want the whole thing generally more left aligned(except for the x out button) rather then taking about the entire available space. I will make this update an cut a new release.
Thank you for your continued testing and feedback.
Hi Schalk - I was looking at the notification markup and css with another mozillian and we thought it might be easier to get the right alignment (progress on left, icon+text+button centered, close on the right) and make it responsive by using grid. Here's a codepen example - https://codepen.io/jensimmons/pen/RVNBdo - this seems to work pretty well.
Thanks @Verdi it looks great, will update.
More in https://drive.google.com/open?id=0B2y0OSD97CR6QnpHVG1lODRrQ3M