search

mozilla / onboard

INACTIVE - http://mzl.la/ghe-archive - The Firefox Onboarding Add-On experiment.
Mozilla Public License 2.0
1 stars 4 forks source link

Missing a selected/visited state for notification button #49

Closed jenniferdavidson closed 7 years ago

jenniferdavidson commented 7 years ago

Tab 1: New tab w/tiles & "Reduce clutter" notification Tab 2: Create a Firefox accounts

On Tab 1, I clicked on the "Sign up for sync" button on step 1 of the Onboarding Tour. It opens a new tab and directs to setting up a Firefox account (Tab 2). After I set up a Firefox account, I went back to Tab 1. The notification is still present, and there is no indication that I clicked the button "Sign up for sync" already.

A potential change (that should be reviewed by verdi/Michelle): When a button has been selected, change the color of the button to indicate that it has been clicked, add a 'checkmark', and/or some text into the button after it has been clicked.

Verdi commented 7 years ago

I wrote the spec to say that we should dismiss the notification when clicked. In the future, with the overlay, clicking the notification will dismiss it and open that section of the overlay.

jenniferdavidson commented 7 years ago

Ah! So the notification should just disappear when the button is clicked. Does that need to be filed as an issue, then?

Verdi commented 7 years ago

Filed https://github.com/mozilla/onboard/issues/53

jenniferdavidson commented 7 years ago

Sounds good. Closing this.