Failed to upload badger from issuer

mozilla / openbadges-backpack

Mozilla Open Badges Backpack

https://backpack.openbadges.org/

Other

862 stars 263 forks source link

Failed to upload badger from issuer #1126

Closed Starli0n closed 7 years ago

Starli0n commented 7 years ago

Hi,

I tried to login from an issuer but the login popup stays when I click on Login (but still code 200 received)
So I click on the cross to close it
I try it again but this time, it seems that I am logged as I see my email

I try the send my badge but I have the error (still with code 200):

You didn't add any open badges to your Backpack.
Visit your Backpack to manage and share your open badges.

I tried on Code School and same goes with the Navigator badge

I am a bit confused...

jessemorton commented 7 years ago

Also experiencing this issue

auralon commented 7 years ago

I've issued a fix for this, but I'm currently hit build errors. Updating some dependencies due to security vulnerabilities has led to a few issues (whereby several tests now need to be rewritten). I'm currently investigating which tests are affected. Once I've ascertained that, then I'll deploy the changes to production so that the issuer functionality works again. Bear with me!

auralon commented 7 years ago

OK, so the fix for this has been tested, staged, and ultimately deployed to the production Backpack. Everything appears to be working as it should now. Please let me know if you continue to experience this issue. Thanks!

Starli0n commented 7 years ago

I tested on navigator-badge login + badge sending

It works fine for me. Thanks a lot.

ahripak commented 7 years ago

I ran into this issue yesterday as well, but it persisted even with the downgrading to Express 4.x.

For me, it ended up being the assertion.recipient hash not matching the internal one that the Backpack would create—which really came down to differences in letter-casing on the email from the assertion and the email on the user record in the Backpack.

Essentially it's the same situation described by the OP, the message that would be returned was You didn't add any open badges to your Backpack. which seems to be a catchall for any unhandled errors where the underlying AJAX request returns an HTTP 200. I was going to submit a pull request to add verbose error handling in this case, but couldn't figure out a good way to do that short of refactoring the badges-complete listener in main.js

auralon commented 7 years ago

Hey @ahripak, how's it going? Although it produces the same result, this issue was due to a different bug. There is another issue #1130 that relates to email casing between the backpack and other systems.