search

mozilla / openbadges-backpack

Mozilla Open Badges Backpack
https://backpack.openbadges.org/
Other
862 stars 263 forks source link

update to oldest possible secure version of Node.js #1147

Closed Pomax closed 6 years ago

Pomax commented 6 years ago

... I have no idea if this even works with Node 4, but 0.10 is definitely a sieve at this point =D

jbuck commented 6 years ago

I think @auralon or @omidmufeeddm would be more appropriate reviewers for this patch based on their recent commit history

auralon commented 6 years ago

I believe there's some further changes that are required in order to get this to work. Bumping the node version alone leads to certain things breaking... at least, it did when I tried it out. However, I can't quite remember what exactly broke off the top of my head though, so further testing is required (we don't have complete coverage with unit tests at present either).

I'll discuss this issue with my colleagues, but I can see that it needs addressing as a matter of urgency!

It's worth mentioning that we'd welcome further patches that help us get a more complete unit test coverage also!