search

mozilla / openbadges-discovery

INACTIVE - http://mzl.la/ghe-archive - Discovery tool for Open Badges including Pathways and Directory
Mozilla Public License 2.0
24 stars 12 forks source link

Annoying corner #405

Closed chloeatplay closed 10 years ago

chloeatplay commented 10 years ago

is annoying. (on banner, aligment seems a bit off) discover open badges 2014-06-09 17-01-30

stenington commented 10 years ago

Oh right, that got introduced with the new background for the animation to play over top of. The background is properly centered on the page... I think the green within the file itself is slightly off center. @zzzndr can you fix?

zzzndr commented 10 years ago

Here are 2 screendumps taken on the mac, I don't have Windows to check unfortunately

  1. In Firefox & Chrome the offset is 4 pixels
  2. In Safari the offset is 5 pixels

Does that mean that something else might cause this bug as well? To have a quick fix, shall I change the graphic to look good on Firefox & Chrome?

  1. Firefox & Chrome debug-1_firefox
  2. Safari debug-1_safari
threeqube commented 10 years ago

whoa, that's so neat! pixel level granularity!

stenington commented 10 years ago

@zzzndr Hmm, let me check again and make sure it's not entirely a problem with the css then before asking for a new graphic.

zzzndr commented 10 years ago

okido!

stenington commented 10 years ago

So I made the background behind the header image purple and took a screen shot of the corners, comparing how far the image overhangs the white center column on each side:

comp

As far as I can see the image is perfectly centered on Firefox, and the jag is because the green isn't centered at the bottom within the overall image.

The 1px discrepancy I'm still looking at, although I can imagine it's just a border width or margin that didn't get set to 0.

zzzndr commented 10 years ago

okido, i'll change the graphic asap!

zzzndr commented 10 years ago

here is a link to the updated header, hope this will be a fix https://www.dropbox.com/s/svb2zyegxq03jit/landingHeaderDesktopBG_v2.svg

the dimensions have remained the same

stenington commented 10 years ago

Cool, pushed through to production and looks good to me. @zzzndr want to confirm?

zzzndr commented 10 years ago

looking good in Firefox & Chrome! safari has a 1 pixel offset (:

stenington commented 10 years ago

@zzzndr what version of safari? I don't see it.

zzzndr commented 10 years ago

i'm running OSX 10.9 with safari Version 7.0.1 it's just 1 pixel though (:

sd_safari

stenington commented 10 years ago

Hmm, so looks fine in Safari 6.1.4. I'll have to figure out how to get my hands on 7.0.1 to debug.

It's possible this comes down to some crazy pixel rounding thing when your browser's viewport is sized to an odd pixel-width or something ridiculous, in which case it might be a bit of a rat-hole to try to fix.

zzzndr commented 10 years ago

ouch, sounds potentially time consuming

chloeatplay commented 10 years ago

I SAY WE CALL TRUCE ON THIS PIXEL WAR. :laughing:

zzzndr commented 10 years ago

\o/