search

mozilla / opmon

Operational Monitoring (OpMon) 📈
Mozilla Public License 2.0
7 stars 5 forks source link

Make `metric`, `statistic`, and possibly `parameter` be `measure` in the generated LookML model behind the dashboard #138

Open ncalexan opened 1 year ago

ncalexan commented 1 year ago

What I would like is to be able to set Looker alerts based on (metric, statistic, possibly parameter, errors). Right now, the only option is based on (errors). That is, on https://mozilla.cloud.looker.com/dashboards/operational_monitoring::firefox_install_demo?Date=&Percentile=50, I currently only get:

Add Looker alert to Alerts table

What I would like is to be able to specify "Any errors" for a single (metric, statistic) pair.

I think this is controlled by https://github.com/mozilla/looker-hub/blob/0279017e7aa2a90df9ad60cddf2d8fe5a873a00a/operational_monitoring/views/firefox_install_demo_alerts.view.lkml, which only lists errors as a measure. I would like to try to bump a few of those dimensions to be measures, but even with my development access, it’s not clear to me how to do that. (That’s before even trying to get https://github.com/mozilla/lookml-generator to arrange that automatically.)

The real use case here is that Looker provides almost no configuration of the alert emails/Slack messages produced by alerts. (Historical test alerts have aged out so I can’t even see what they look like at this point.)

┆Issue is synchronized with this Jira Task

ncalexan commented 1 year ago

From @scholtzan in this Slack thread: "The problem with measures is that you need to define some sort of aggregation (sum, mean, etc) which in some cases could produce wrong results. I can see if there is a way to use something like FIRST_VALUE to convert these into measures."